Hopefully this will be addressed after I finish the thread/task rewrite. Adam K
On 9 April 2010 14:06, Andrew Bramble <bramble.and...@gmail.com> wrote: > Agree - dot '.' probably should not be classed as an installed modules > location :0 > > Sadly this addresses only part of a wider problem. > > The traversal of filesystem and seeming enumeration of the universe > that occurs when the 'F2 Help Search' is invoked is performed by the > main thread rather than behind the scenes. Chances are the user gives > up long before this finishes and returns control to the user. > > Hence if you have installed lots of cpan modules , this problem persists. > > On Thu, Apr 8, 2010 at 7:05 PM, Damyan Ivanov <d...@debian.org> wrote: >> Hi, >> >> While testing the (almost finished) Debian package of padre 0.59, this >> is what happened: >> >> I ran padre from my home directory, loaded a file, moved the cursor to >> the end, over an exit() call and pressed F2. >> >> A new window appeared, saying 'Reading items. Please wait.'. Then my >> disk started seeking and padre appeared to be stuck. >> >> Poking with lsof showed that padre walks over my home directory >> contents. I have a huge home directory (a Svn checkout of all the perl >> module packages handled by the Debian Perl Group -- over 1600), so >> I interrupted it. >> >> Further investigation shows that padre tries to find all available >> Perl modules via the _find_installed_modules routine in >> Padre::Document::Perl::Help. This involves recursively scanning all >> directories foind in @INC. For some reason, perl's @INC on Debian >> includes the '.' directory, and since I started padre from my home >> directory, I got a nice DoS. >> >> My proposal is to skip searching the '.' directory in >> _find_installed_modules. An IRC query suggested that I mail before >> committing, so here we go :) >> >> Are there objections against skipping '.' when finding installed >> modules? >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v1.4.9 (GNU/Linux) >> >> iQIcBAEBCAAGBQJLvZxaAAoJEOQbTFV/DYC+leEP/RzLVVlpO2sVjTpLwQPojTNz >> l9ItiY8QJqmtiNFUijqmCXYUkh922L1z6rghsmwgIgCLEpn2/8VeRLjo4VxOJ8j+ >> wQXvXHx+VvDxStMIjWYiI43HWU1AFslhtBd+dqFDHYBYhtPIAuDXuy/m69sFX91t >> tXPI7/oF6xZ+UnryOmoBe0COa2o4TfjFZfmJXSWQxitrcNN6U/w1/ok96ODpvlHA >> 2VGu/xtA0hSfIdsrfLnukbKsk4HgPtnhlP59KVJ1EhJi4k370DLSJmjqVNuQBadn >> asbYOYb0t6KE93+jj2Eg7+MpeYoMvyCJ3BjG1RstIa7aRKLajAOd1bKXZPQ2pg4O >> 5w1SDMCIzo2KJuxjgwE/bq17+iyS/5Pr98NGqLRzAoZfLzFnryTm2CShKuXYei+h >> ITHI5urC2VLz4jUBsjiW9Fkj6zO2fbAsyfu5G62idXCmouQzHGk5nGnfaZFXk1/j >> 9Idepxzvxrm6+SZuOFX5XDWoByKMla8SkaN7I6K7YJmyf/er/2iICMpZrIDA5uIo >> etSotDUjb2VpCl5YLr84VUulNlK2icOfBYd9qgC9Pst9B9XELQlDBVSmGPwTwjNW >> GAaQTdykc9dREorHohLEJtbYEBW85BqKQg0A+omIdZQ4NkuQOE8eljaCriZvlnvl >> wuPRJC+8h3X05JDjELCU >> =qLsB >> -----END PGP SIGNATURE----- >> >> _______________________________________________ >> Padre-dev mailing list >> Padre-dev@perlide.org >> http://mail.perlide.org/mailman/listinfo/padre-dev >> >> > _______________________________________________ > Padre-dev mailing list > Padre-dev@perlide.org > http://mail.perlide.org/mailman/listinfo/padre-dev > _______________________________________________ Padre-dev mailing list Padre-dev@perlide.org http://mail.perlide.org/mailman/listinfo/padre-dev
