Hi Sam, Please visit the #padre irc channel on irc.perl.org and ask the people there to open the trac registration - we need to keep it closed due to spam - regards Gabor
On Mon, Apr 12, 2010 at 8:24 AM, Sam Crawley <sam_craw...@warpmail.net> wrote: > Hi, > > I'm interested in doing a bit of Padre hacking. To get familiar with the > codebase, I picked a bug that I thought looked simple, and tried to fix it. > Turned out it was (patch attached). > > This fixes the bug reported in Trac #896, relating to find history. There > was a small logic error causing the problem, which was actually more general > than reported. Search terms weren't getting added to the history in a lot of > cases. > > I've also included a unit test, which makes use of Test::MockObject (I've > added this as a requirement in Makefile.PL). Hope the extra dep is OK... I > think T::MO will be pretty useful in a number of other cases, as a lot of > the constructors, base classes, etc. are quite heavy duty, and it can make > it difficult to test some simple logic without it. > > Anyway, could I please also get a Trac account setup so I can attach patches > / comments directly to the defects in future. > > Thanks, > Sam. _______________________________________________ Padre-dev mailing list Padre-dev@perlide.org http://mail.perlide.org/mailman/listinfo/padre-dev
