Hi everyone,
I'm copying the failing tests if someone who knows what to fix will be
able to check into them.
I have for the most part fixed the simple ones, which turned out to be
EOL problems, however the following I don't know enough to fix:
xt/critic-core.t ........... 25/211
# Failed test 'Test::Perl::Critic for
"blib/lib/Padre/PluginManager.pm"'
# at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in
"blib/lib/Padre/PluginManager.pm":
# Don't turn off strict for large blocks of code at line 644, column 3.
See page 433 of PBP. (Severity: 4)
Looking at the code itself, it doesn't look like a large block of code.
I'm not sure what to do here.
xt/critic-core.t ........... 71/211
# Failed test 'Test::Perl::Critic for
"blib/lib/Padre/Plugin/Devel.pm"'
# at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in
"blib/lib/Padre/Plugin/Devel.pm":
# Comma used to separate statements at line 21, column 2. See pages
68,71 of PBP. (Severity: 4)
OK, this seems simple if I'm right:
sub padre_interfaces {
'Padre::Plugin' => 0.66,
'Padre::Wx' => 0.66,
'Padre::Wx::Main' => 0.66,
'Padre::Wx::History::TextEntryDialog' => 0.66,
;
}
is this the same thing:
return(
'Padre::Plugin' => 0.66,
'Padre::Wx' => 0.66,
'Padre::Wx::Main' => 0.66,
'Padre::Wx::History::TextEntryDialog' => 0.66,
);
?
If so, the same problem is in the next failed test:
# Failed test 'Test::Perl::Critic for "blib/lib/Padre/Plugin/My.pm"'
# at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "blib/lib/Padre/Plugin/My.pm":
# Comma used to separate statements at line 22, column 2. See pages
68,71 of PBP. (Severity: 4)
xt/critic-core.t ........... 211/211 # Looks like you failed 3 tests of
211.
xt/critic-core.t ........... Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/211 subtests
This one looks great.. unexpectedly passed a test:
xt/badcode.t ............... 40/1929
# Failed test ''Padre' does not use Wx'
# at xt/badcode.t line 117.
# use Padre::Wx::ActionQueue ();
xt/badcode.t ............... 1911/1929 # Looks like you failed 1 test of
1929.
xt/badcode.t ............... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1929 subtests
(less 455 skipped subtests: 1473 okay)
(2 TODO tests unexpectedly succeeded)
That's about it for now.
Thanks,
Pete.
_______________________________________________
Padre-dev mailing list
Padre-dev@perlide.org
http://mail.perlide.org/mailman/listinfo/padre-dev
