OK, two tests are failing: xt/critic-core.t ........... 1/236 # Failed test 'Test::Perl::Critic for "blib/lib/Padre.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/Padre.pm": # Magic variable "$ENV" should be assigned as "local" at line 181, column 17. See pages 81,82 of PBP. (Severity: 4) xt/critic-core.t ........... 236/236 # Looks like you failed 1 test of 236. xt/critic-core.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/236 subtests xt/critic-util.t ........... 2/53 # Failed test 'Test::Perl::Critic for "t/04-config.t"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "t/04-config.t": # Two-argument "open" used at line 41, column 2. See page 207 of PBP. (Severity: 5) # Close filehandles as soon as possible after opening them at line 41, column 2. See page 209 of PBP. (Severity: 4) xt/critic-util.t ........... 53/53 # Looks like you failed 1 test of 53. xt/critic-util.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/53 subtests
Now I seem to recall that Adam might have fixed these, but not sure if they got committed only to trunk.. because it's not in the branch. For the most part these are just critic fails, it doesn't really effect the release so much itself, given it's a fairly simple fix for both cases. Not only that, these are xt tests that get run when you have certain settings set, ie RELEASE_TESTING, which install doesn't. Should these be fixed in the release trunk before releasing and merge back to trunk after the release, or just fix in trunk and move on? Peter.
_______________________________________________ Padre-dev mailing list Padre-dev@perlide.org http://mail.perlide.org/mailman/listinfo/padre-dev
