> 1) There's no need for the ?: operator: Awsome, I missed that :).
> 2) Variable names like Field2, Field3 are a "smell." Why not > use an array > and a loop? I changed the names to protect the innocent. > > 3) I'm not at all certain this is even legal C code. You're > changing len and > evaluating it in the same expression. Which side of the + > operator should be > evaluated first? You're lucky your monitor didn't blow up. :) Well it works w/o optimizations on. I was of the understanding C evaluated by precedence 1st and then left to right. I agree its nutty but I was saving some lines :). > 4) Are you sure you don't want to store the null byte at the > end of empty > fields? How will you know when a field is empty when you read > it back again? Yeah I'm sure. PackedHistoricStruct takes care of that it knows how big records are and what fields are there. Thanks for looking everyone (Ben and Oliver too). Guess the compiler showed me who was smarter :). Mike -- For information on using the Palm Developer Forums, or to unsubscribe, please see http://www.palmos.com/dev/support/forums/
