FYI, I've committed this change: /cvsroot/ParaView3/ParaView3/CMake/ParaViewPlugins.cmake,v <-- CMake/ParaViewPlugins.cmake new revision: 1.70; previous revision: 1.69
On Thu, Mar 18, 2010 at 2:41 PM, Mike Jackson <[email protected]> wrote: > Cool thanks. > _________________________________________________________ > Mike Jackson [email protected] > > On Thu, Mar 18, 2010 at 2:28 PM, Dave Partyka <[email protected]> > wrote: >> Yeah, it should be fine to remove ${name}. In 3.6 it was done for >> organizational purposes for the most part. >> >> On Thu, Mar 18, 2010 at 2:23 PM, Utkarsh Ayachit >> <[email protected]> wrote: >>> >>> Ah..yes...well it's not a bug per say. We did that in past to make it >>> easier for people to locate plugins that are packaged with ParaView, >>> but we don't need that anymore since distributed plugins are >>> automatically listed by the plugin manager dialog. I think we should >>> remove the ${name}. Dave, any concerns with doing so? >>> >>> Utkarsh >>> >>> On Thu, Mar 18, 2010 at 10:58 AM, Michael Jackson >>> <[email protected]> wrote: >>> > I was running the "install" target from a Visual Studio instance and >>> > noticed >>> > that my custom client side plugins were NOT being loaded. When I looked >>> > at >>> > the install tree I noticed the following: >>> > >>> > ParaView/bin/plugins/AngReaderClientPlugin/AngReaderClientPlugin.dll >>> > which >>> > obviously is not correct. I think I have tracked it down to the >>> > following >>> > bit of CMake code in ParaView/CMake/ParaViewPlugins.cmake: >>> > >>> > MACRO(internal_paraview_install_plugin name) >>> > IF (PV_INSTALL_LIB_DIR) >>> > INSTALL(TARGETS ${name} >>> > ==> DESTINATION "${PV_INSTALL_PLUGIN_DIR}/${name}" >>> > COMPONENT Runtime) >>> > ENDIF (PV_INSTALL_LIB_DIR) >>> > ENDMACRO(internal_paraview_install_plugin) >>> > >>> > I think that should be DESTINATION "${PV_INSTALL_PLUGIN_DIR}/" instead. >>> > Is >>> > this a bug? Something similar to this error is also present in the >>> > ParaView >>> > 3.6.2 sources (where I originally found the issue). >>> > >>> > Thanks for any info/feedback. >>> > ___________________________________________________________ >>> > Mike Jackson www.bluequartz.net >>> > Principal Software Engineer [email protected] >>> > BlueQuartz Software Dayton, Ohio >>> > >>> > >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Please keep messages on-topic and check the ParaView Wiki at: >>> > http://paraview.org/Wiki/ParaView >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://www.paraview.org/mailman/listinfo/paraview >>> > >> >> > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
