Great. There should probably be some documentation updates to let developers know that the variable needs to be turned on so that their plugins will get copied. I still need to try this on windows.
----- Mike Jackson www.bluequartz.net Principal Software Engineer [email protected] BlueQuartz Software Dayton, Ohio On May 17, 2010, at 18:28, Dave Partyka <[email protected]> wrote: Hi Mike, I committed your patch to master and cherry picked it onto the release branch. On Mon, May 17, 2010 at 9:41 AM, Michael Jackson < [email protected]> wrote: > 519:[mjack...@ferb:ParaView]$ git diff > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 45eef61..6698fcc 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -26,6 +26,11 @@ GET_PROPERTY(PV_TARGET_SUPPORTS_SHARED_LIBS > SET(PARAVIEW_PLUGINLIST_TXT "${ParaView_BINARY_DIR}/PluginList.txt") > FILE(WRITE ${PARAVIEW_PLUGINLIST_TXT} "") > > + > ######################################################################### > +# PARAVIEW_PLUGINLIST is used to generate the config file distributed with > +# ParaView that lists the plugins distributed with ParaView. > +SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" > FORCE) > + > SET(PARAVIEW_PLUGIN_CONFIG_LIST "" CACHE INTERNAL "List of configured > plugins.") > > ######################################################################### > @@ -313,10 +318,7 @@ SET(PARAVIEW_SMTESTDRIVER_EXECUTABLE > ${EXECUTABLE_OUTPUT_PATH}/smTestDriver${ > # release/debug configuration gets considered. > GET_TARGET_PROPERTY(PARAVIEW_PROCESS_XML_EXECUTABLE kwProcessXML LOCATION) > > -######################################################################### > -# PARAVIEW_PLUGINLIST is used to generate the config file distributed with > -# ParaView that lists the plugins distributed with ParaView. > -SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" > FORCE) > + > ADD_SUBDIRECTORY(Plugins) > > ######################################################################### > > That is the first change. The issue with BUILD_PARAVIEW_PLUGINLIST I am not > sure where that should properly be enabled. Currently it is enabled in > ParaView/Plugins/CMakeLists.txt at the top of the file. If someone uses the > PARAVIEW_EXTRA_EXTERNAL_MODULES I don't think the BUILD_PARAVIEW_PLUGINLIST > gets enabled in the proper sequence. So I guess it comes down to is it the > responsibility of the programmer to enable it or should it get enabled if > the ADD_PARAVIEW_PLUGIN is called which would cover all the bases? > ___________________________________________________________ > > Mike Jackson www.bluequartz.net > > > > On May 14, 2010, at 9:10 PM, Dave Partyka wrote: > > Cool okay! Can you make a proper git patch against Master and send it to >> the list? I will apply it and cherry pick it into the list. >> >> On Fri, May 14, 2010 at 7:40 PM, Michael Jackson < >> [email protected]> wrote: >> There is another cmake variable "BUILD_PARAVIEW_PLUGINLIST" which needs to >> be enabled in the *ParaViewImport.cmake file. I added SET >> (BUILD_PARAVIEW_PLUGINLIST ON) to my PVMXADataModelParaViewImport.cmake file >> (and with the other corrections) I now can do a "make install" and have >> ParaView.app include my plugins. So where should I send a patch? >> >> Now.. if I could only convince "make install" to actually install >> ParaView.app where I want that would be great. No Write privs in >> /Applications. >> -- >> >> Mike Jackson <www.bluequartz.net> >> >> On May 14, 2010, at 5:12 PM, Michael Jackson wrote: >> >> Ok, >> So here is the problem. The PARAVIEW_EXTRA_EXTERNAL_MODULES is called in >> the top level ParaView CMakeLists.txt file. AFTER that call the line: >> SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" >> FORCE) >> >> is called which wipes out any plugins that were added by External Modules. >> So one needs to initialize the PARAVIEW_PLUGINLIST BEFORE the line: >> >> INCLUDE(ParaViewCommon) >> >> is executed: >> >> But that still didn't work but is probably part of the problem >> ___________________________________________________________ >> Mike Jackson www.bluequartz.net >> >> On May 14, 2010, at 1:40 PM, Dave Partyka wrote: >> >> Hi Mike, >> >> Do you mind trying to print some messages then? When you call >> ADD_PARAVIEW_PLUGIN the plugin gets Appended to PARAVIEW_PLUGINLIST and also >> install rules should be created. Can you add this line say in >> Applications\ParaView\CMakeLists.txt and then configure and see if you're >> plugins get printed in the list of plugins? >> >> message("PARAVIEW_PLUGINLIST ${PARAVIEW_PLUGINLIST}") >> >> On Fri, May 14, 2010 at 11:02 AM, Michael Jackson < >> [email protected]> wrote: >> This is still NOT working on the latest pull of the "release" branch of >> ParaView. I can NOT simply do a "make install" on OS X and have my custom >> plugins copied into the Application Bundle along with any other plugins that >> are included with ParaView. >> ___________________________________________________________ >> >> Mike Jackson www.bluequartz.net >> >> On Apr 26, 2010, at 11:47 AM, Michael Jackson wrote: >> >> Thanks, I'll give that a try. "Make install" does fixup the bundle >> correctly. I just left out my plugins. >> >> So I have to do a cpack run in order to get a working installation on my >> local machine? ie, an "installation" that is NOT in my build directory? >> Seems odd. >> >> -- >> Mike Jackson <www.bluequartz.net> >> >> On Apr 26, 2010, at 11:05 AM, Dave Partyka wrote: >> >> I would recommend: >> >> cpack --config <build-dir>/Applications/ParaView/CPackParaViewConfig.cmake >> -G DragNDrop >> >> As per: http://paraview.org/Wiki/ParaView:Build_And_Install >> >> If you do make install I believe it just runs all install rules and I >> don't believe any of the fixup bundle routines get called. >> >> On Mon, Apr 26, 2010 at 9:43 AM, Michael Jackson < >> [email protected]> wrote: >> Just tried a 'Make install' and after installation (to the wrong >> directory**) my custom plugins that are built as part of ParaView (using >> PARAVIEW_EXTRA_EXTERNAL_MODULE). Is this going to be fixed before the full >> release comes out? >> >> >> **I have a CMAKE_INSTALL_PREFIX of /Users/Shared/Toolkits/ParaView-3.8 but >> when I run 'make install' ParaView gets installed into /Applications? I >> tried exporting DESTDIR=$CMAKE_INSTALL_PATH but that did not seem to help >> either. I do not have write access to /Applications for this user account so >> this "feature" is a real problem. >> >> ___________________________________________________________ >> Mike Jackson www.bluequartz.net >> Principal Software Engineer [email protected] >> BlueQuartz Software Dayton, Ohio >> >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the ParaView Wiki at: >> http://paraview.org/Wiki/ParaView >> >> Follow this link to subscribe/unsubscribe: >> http://www.paraview.org/mailman/listinfo/paraview >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the ParaView Wiki at: >> http://paraview.org/Wiki/ParaView >> >> Follow this link to subscribe/unsubscribe: >> http://www.paraview.org/mailman/listinfo/paraview >> >> >
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
