It gets configured into CMake\branded_paraview_initializer.cxx.in as BPC_TITLE. The configuration magic happens in ParaViewBranding.cmake. The idea behind the branding code was to make creating generic paraview based applications easy. I am hesitant about putting the ifdefs at the C++ level as that would effect everyone using ParaView branded applications.
On Mon, Feb 7, 2011 at 12:25 PM, Michael Jackson < [email protected]> wrote: > I would have thought that some sort of header file would be created with > all the preprocessor logic and then the actual Qt code would call out to > that header file to get the correct QString to display in the title. Just > having "Universal" in the header may or may not be good enough. I think I > would really want to know in what mode (32 or 64 bit) it was truly running. > Is that what is happening? I am having trouble following exactly where the > "TITLE" argument to the build_paraview_client function is actually being > used. > ___________________________________________________________ > Mike Jackson www.bluequartz.net > > > On Feb 7, 2011, at 12:04 PM, David Partyka wrote: > > > The bitness comes from ParaViewCommon.cmake around line 280 and passed > into build_paraview_client in Applications/ParaView/CMakeLists.txt around > line 49. I guess in this case the title should be Universal, what do you > think? I have similar logic that generates the dmg name that way. i.e. if > there are more than one target platforms then call it Darwub-Universal. > > > > > > On Mon, Feb 7, 2011 at 11:00 AM, Michael Jackson < > [email protected]> wrote: > > Yes. I was doing a universal build targeted for 10.5 but using a 10.6 to > build. Do you have a hint as to where that title is generated? I'll try and > put together a patch. > > > > ___________________________________________________________ > > Mike Jackson www.bluequartz.net > > > > > > On Feb 7, 2011, at 10:57 AM, David Partyka wrote: > > > > > Humm, curious if you doing a universal build then? Yeah please file a > bug and I'll make sure it's fixed for 3.10.0 final. > > > > > > On Mon, Feb 7, 2011 at 10:37 AM, Michael Jackson < > [email protected]> wrote: > > > Just compiled the latest ParaView from git (master) and when I launched > the app I noticed at the top that it had "32 Bit" in the title. Just to > verify my version was actually a 64 bit version. My guess is that when that > title is generated in code there should be some preprocessor logic to figure > out just how it was built. Relying on the sizeof(void*) probably isn't the > best idea: > > > > > > > > > #if !defined(__APPLE__) > > > Compute title for NON Apple Platforms > > > #else > > > # if defined(__LP64__) && __LP64__ > > > 64 BIt title > > > # else > > > 32 bit title > > > # endif > > > > > > #endif > > > > > > Should I put in a formal bug report? > > > > > > Thanks > > > ___________________________________________________________ > > > Mike Jackson www.bluequartz.net > > > Principal Software Engineer [email protected] > > > BlueQuartz Software Dayton, Ohio > > > > > > _______________________________________________ > > > Powered by www.kitware.com > > > > > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > > > > > Please keep messages on-topic and check the ParaView Wiki at: > http://paraview.org/Wiki/ParaView > > > > > > Follow this link to subscribe/unsubscribe: > > > http://www.paraview.org/mailman/listinfo/paraview > > > > > > > > >
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
