Sorry I hit send too early:
>> * ParaViewCore/ServerManager/vtkSMDataSourceProxy.{cxx,h} are orphaned
>> (have no reference from other sources or CMakeLists).
>
> Yes, I was planning to remove it. Are you using it ?
No.
Takuya
Takuya OSHIMA, Ph.D.
Faculty of Engineering, Niigata University
8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN
From: Sebastien Jourdain <[email protected]>
Subject: Re: [Paraview] ANN: Upcoming changes to ParaView Server Manager
Date: Tue, 29 Mar 2011 08:37:14 -0400
> Hi Takuya,
>
> I'm glad that you gave a try and you managed to make your plugin work.
> Moreover, thanks for that "cheat sheet".
>
> Here is my feedback about it:
>
>> OLD: pxy->Set/GetServers() (where pxy is a vtkSMProxy)
>> NEW: pxy->Set/GetLocation()
>
> Yes
>
>> OLD: pxy->Set/GetConnectionID()
>> NEW: pxy->Set/GetSession()
>
> Yes, but those lines should simply be removed as the session is set on
> the Proxy at its creation, therefore there is no point in doing it
> twice.
>
>> OLD: pxy->GetID()
>> NEW: VTKOBJECT(pxy) (a stream operator in client-server stream)
>
> Yes
>
>> OLD: pm->SendSteram(this->GetConnectionID(), this->GetServers(), stream)
>> NEW: this->ExecuteStream(stream) (where this is a vtkSMProxy)
>
> Yes
>
>> OLD: pm->SendStream(pxy->GetConnectionID(), pxy->GetServers(), stream)
>> NEW: pxy->GetSession()->ExecuteStream(pxy->GetLocation(), stream)
>> (where pm is a vtkProcessModule)
>
> Yes, but as you did it previously you can also do that
> NEW2: pxy->ExecuteStream(stream)
>
>> Also, what I noticed so far are
>> * CoProcessing module does not build due to some missing headers.
>
> I'm going to look into that and fix it. Thanks to have notice it.
>
>> * ParaViewCore/ServerManager/vtkSMDataSourceProxy.{cxx,h} are orphaned
>> (have no reference from other sources or CMakeLists).
>
> Yes, I was planning to remove it. Are you using it ?
>
> Thanks again for those valuable comments,
>
> Seb
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the ParaView Wiki at:
http://paraview.org/Wiki/ParaView
Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview
