Sohail, I've tracked this issue down. Attached is the patch. I'll get this fix in 3.12.
Utkarsh On Tue, Aug 9, 2011 at 2:30 PM, Andy Bauer <[email protected]> wrote: > I forgot to mention that that one only has 2 time steps. I have a sample > one with 4 time steps too if you need it. > > On Tue, Aug 9, 2011 at 2:28 PM, Andy Bauer <[email protected]> wrote: >> >> Yes, it's in <VTKLargeData>/Data/WindBladeReader. Select the >> test1_topo.wind file. >> >> Andy >> >> On Tue, Aug 9, 2011 at 2:06 PM, Sohail Shafii <[email protected]> >> wrote: >>> >>> I believe Andy should have at least one lying around. >>> Sohail >>> ________________________________ >>> From: Utkarsh Ayachit <[email protected]> >>> To: Sohail Shafii <[email protected]> >>> Cc: "[email protected]" <[email protected]> >>> Sent: Tuesday, August 9, 2011 11:07 AM >>> Subject: Re: [Paraview] Comparative view and wind blade reader >>> >>> Ah, it's possible that the view has issues with multiple output ports, >>> I don't think I ever verified that. I forget, is there any small >>> dataset I can test this with already in ParaView (or where can I get >>> it) ? >>> >>> Utkarsh >>> >>> On Tue, Aug 9, 2011 at 11:39 AM, Sohail Shafii <[email protected]> >>> wrote: >>> > Hi, >>> > I have recently become interested in comparing different time steps >>> > using >>> > the windblade reader. One approach involves a 3D comparative view. >>> > After >>> > loading my .wind data set, I created a 2X1 Comparative View. In the >>> > Comparative View Inspector, I clicked the "+" symbol when "Time" was >>> > selected. I can view the Field portion without problems in either view >>> > (with different timesteps for each view), but when I select Blade, the >>> > first >>> > view renders it correctly while the second view renders a surface >>> > around the >>> > data set. When I select Ground, the first view renders the item >>> > correctly >>> > while the second renders the data set's outline. I wonder if >>> > Comparative >>> > view has issues with multiple ports. Any ideas? >>> > Thank you, >>> > Sohail >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Please keep messages on-topic and check the ParaView Wiki at: >>> > http://paraview.org/Wiki/ParaView >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://www.paraview.org/mailman/listinfo/paraview >>> > >>> > >>> >>> >> > >
commit 0e4dabda4a779813685e219fe1a6071b9c9e890e Author: Utkarsh Ayachit <[email protected]> Date: Tue Aug 30 10:36:24 2011 -0400 Fixed BUG #12559. vtkSMInputProperty was missing a Copy/DeepCopy. vtkSMInputProperty was missing a Copy/DeepCopy. That was casuing the comparative view to set up representations incorrectly when a source had multple output ports. diff --git a/ParaViewCore/ServerManager/vtkSMInputProperty.cxx b/ParaViewCore/ServerManager/vtkSMInputProperty.cxx index 8144bdb..949ad1a 100644 --- a/ParaViewCore/ServerManager/vtkSMInputProperty.cxx +++ b/ParaViewCore/ServerManager/vtkSMInputProperty.cxx @@ -443,3 +443,46 @@ int vtkSMInputProperty::LoadState(vtkPVXMLElement* element, this->ImmediateUpdate = prevImUpdate; return 1; } + +//--------------------------------------------------------------------------- +void vtkSMInputProperty::Copy(vtkSMProperty* src) +{ + int imUpdate = this->ImmediateUpdate; + this->ImmediateUpdate = 0; + + this->Superclass::Copy(src); + + vtkSMInputProperty* dsrc = vtkSMInputProperty::SafeDownCast(src); + if (dsrc) + { + this->IPInternals->OutputPorts = dsrc->IPInternals->OutputPorts; + this->IPInternals->UncheckedOutputPorts = + dsrc->IPInternals->UncheckedOutputPorts; + } + + this->ImmediateUpdate = imUpdate; + this->Modified(); +} + +//--------------------------------------------------------------------------- +void vtkSMInputProperty::DeepCopy(vtkSMProperty* src, + const char* exceptionClass, int proxyPropertyCopyFlag) +{ + vtkSMInputProperty* dsrc = vtkSMInputProperty::SafeDownCast(src); + int imUpdate = this->ImmediateUpdate; + this->ImmediateUpdate = 0; + + this->Superclass::DeepCopy(src, exceptionClass, proxyPropertyCopyFlag); + if (dsrc) + { + this->IPInternals->OutputPorts = dsrc->IPInternals->OutputPorts; + this->IPInternals->UncheckedOutputPorts = + dsrc->IPInternals->UncheckedOutputPorts; + } + + this->ImmediateUpdate = imUpdate; + if (this->ImmediateUpdate) + { + this->Modified(); + } +} diff --git a/ParaViewCore/ServerManager/vtkSMInputProperty.h b/ParaViewCore/ServerManager/vtkSMInputProperty.h index 0cabe94..72f5eaa 100644 --- a/ParaViewCore/ServerManager/vtkSMInputProperty.h +++ b/ParaViewCore/ServerManager/vtkSMInputProperty.h @@ -113,6 +113,18 @@ public: vtkSetMacro(PortIndex, int); vtkGetMacro(PortIndex, int); + // Description: + // Copy all property values. + virtual void Copy(vtkSMProperty* src); + + // Description: + // Copy all proxies added to the src over to this by creating new + // instances for the proxies and inturn calling Copy to copy + // the proxies. exceptionClass and proxyPropertyCopyFlag are + // used while copying over the values from the two proxy properties. + virtual void DeepCopy(vtkSMProperty* src, const char* exceptionClass, + int proxyPropertyCopyFlag); + protected: vtkSMInputProperty(); ~vtkSMInputProperty();
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
