I have a fix for this pushed into git-next. Attached is the patch. The fix will make it into 3.14.
Thanks, Utkarsh On Wed, Feb 15, 2012 at 12:04 PM, Utkarsh Ayachit <[email protected]> wrote: > Ah. I can check it out. > > Utkarsh > > On Wed, Feb 15, 2012 at 11:55 AM, Paul Edwards <[email protected]> > wrote: >> Utkarsh, >> >> That would be fine only the problem is that it *looks* like the object is >> selected in the pipeline browser and you need to click away and back to the >> object in order to actually select it (in order to use the object inspector >> or change representation). >> >> Regards, >> Paul >> >> >> On 15 February 2012 16:10, Utkarsh Ayachit <[email protected]> >> wrote: >>> >>> I believe this was done intentionally. It was noted that people often >>> need to change the "eye" status for some other filter while editing >>> parameters for another and then to it ended up being quite annoying >>> that the "active" source changed when one clicked on the eye ball. I'm >>> pretty positive this has been the case since very early 3.* days. >>> >>> If there's consensus, one way or another, it's an easy fix. >>> >>> Utkarsh >>> >>> >>> >>> On Wed, Feb 15, 2012 at 7:49 AM, Paul Edwards <[email protected]> >>> wrote: >>> > >>> > >>> > This has caught me out many times - I never did work out the steps to >>> > reproduce or I was going to report it! >>> > >>> > On 15 February 2012 10:54, Biddiscombe, John A. <[email protected]> >>> > wrote: >>> >> >>> >> How about left click on eye, toggles visibility and also activates >>> >> panels, >>> >> right click just toggle visibility for quick enable/disable >>> >> >>> >> Currently, right click pops up the context menu, but that could be left >>> >> for the pipeline object itself and the eye handled separately. >>> >> >>> >> just thinking out loud >>> >> >>> >> JB >>> >> >>> >> -----Original Message----- >>> >> From: [email protected] >>> >> [mailto:[email protected]] >>> >> On Behalf Of Biddiscombe, John A. >>> >> Sent: 15 February 2012 11:45 >>> >> To: Gena Bug; [email protected] >>> >> Subject: Re: [Paraview] 3.14 RC2, display tab mismatch selected data in >>> >> the pipeline >>> >> >>> >> +1 >>> >> >>> >> It has caught me out a few times as I change the representation of the >>> >> object I think I'm editing, but it's actually the wrong one. >>> >> >>> >> -----Original Message----- >>> >> From: [email protected] >>> >> [mailto:[email protected]] >>> >> On Behalf Of Gena Bug >>> >> Sent: 15 February 2012 11:37 >>> >> To: [email protected] >>> >> Subject: [Paraview] 3.14 RC2, display tab mismatch selected data in the >>> >> pipeline >>> >> >>> >> Hi! >>> >> >>> >> I've noticed that clicking on 'eye' (make data visible) also selects >>> >> data >>> >> in the pipeline but doesn't update tabs (properties, display and info). >>> >> >>> >> Steps to reproduce: >>> >> 1. open any data >>> >> 2. clip it for example (in that case original data become invisible) 3. >>> >> click on 'eye' to make original data visible (this action will also >>> >> select >>> >> data in the >>> >> pipeline) >>> >> 4. see the props, display and info tab -- they still contain data of >>> >> previous selected data. >>> >> >>> >> P.S. Debian testing amd64, ParaView 3.14 RC2 installed from binaries >>> >> from >>> >> the site. >>> >> >>> >> -----|- >>> >> Gena. >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Please keep messages on-topic and check the ParaView Wiki at: >>> >> http://paraview.org/Wiki/ParaView >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://www.paraview.org/mailman/listinfo/paraview >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Please keep messages on-topic and check the ParaView Wiki at: >>> >> http://paraview.org/Wiki/ParaView >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://www.paraview.org/mailman/listinfo/paraview >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Please keep messages on-topic and check the ParaView Wiki at: >>> >> http://paraview.org/Wiki/ParaView >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://www.paraview.org/mailman/listinfo/paraview >>> > >>> > >>> > >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Please keep messages on-topic and check the ParaView Wiki at: >>> > http://paraview.org/Wiki/ParaView >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://www.paraview.org/mailman/listinfo/paraview >>> > >> >>
From d2d6c7f4640046c929072982032b6319eb440797 Mon Sep 17 00:00:00 2001 From: Utkarsh Ayachit <[email protected]> Date: Wed, 15 Feb 2012 14:14:25 -0500 Subject: [PATCH] Fixed BUG #12940. Fixed setting of active source when clicking on eyeball. --- Qt/Components/pqPipelineBrowserWidget.cxx | 2 +- Qt/Components/pqSelectionAdaptor.cxx | 4 ++++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/Qt/Components/pqPipelineBrowserWidget.cxx b/Qt/Components/pqPipelineBrowserWidget.cxx index b61e978..625b85a 100644 --- a/Qt/Components/pqPipelineBrowserWidget.cxx +++ b/Qt/Components/pqPipelineBrowserWidget.cxx @@ -184,7 +184,7 @@ void pqPipelineBrowserWidget::handleIndexClicked(const QModelIndex &index_) { QModelIndex itemIndex = this->getModel()->index(index_.row(), 0, index_.parent()); - this->getSelectionModel()->select(itemIndex, + this->getSelectionModel()->setCurrentIndex(itemIndex, QItemSelectionModel::ClearAndSelect); } } diff --git a/Qt/Components/pqSelectionAdaptor.cxx b/Qt/Components/pqSelectionAdaptor.cxx index 354532b..94b594c 100644 --- a/Qt/Components/pqSelectionAdaptor.cxx +++ b/Qt/Components/pqSelectionAdaptor.cxx @@ -53,6 +53,10 @@ pqSelectionAdaptor::pqSelectionAdaptor(QItemSelectionModel* _parent) SIGNAL(selectionChanged(const QItemSelection&, const QItemSelection&)), this, SLOT(selectionChanged())); + QObject::connect(this->QSelectionModel, + SIGNAL(currentChanged(const QModelIndex&, const QModelIndex&)), + this, SLOT(selectionChanged())); + pqActiveObjects* ao = &pqActiveObjects::instance(); QObject::connect(ao, SIGNAL(portChanged(pqOutputPort*)), this, SLOT(currentProxyChanged())); -- 1.7.2.5
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
