Great. The fixes are in and will be included in the upcoming release. Thanks for helping track this one down.
Utkarsh On Sat, Mar 17, 2012 at 5:57 AM, Francisco Caraballo <[email protected]> wrote: > Those patches did work perfectly Utkarsh. Great work! > > Thank you very much for all your help. > > Saludos/greetings, > > Francisco Caraballo > > > > On Fri, Mar 16, 2012 at 7:46 PM, Utkarsh Ayachit > <[email protected]> wrote: >> Francisco, >> >> Hopefully this should do it. I tested on my Windows build as well and >> seems to work as expected. >> >> Attached as the new set of files to be placed as follows: >> PV.CMakeLists.txt ==> >> <ParaViewSource>/ParaViewCore/ServerImplementation/CMakeLists.txt >> PROTOBUF.CMakeLists.txt ==> >> <ParaViewSource>/Utilities/protobuf/CMakeLists.txt >> PROTOBUF.src.CMakeLists.txt ==> >> <ParaViewSource>/Utilities/protobuf/src/CMakeLists.txt >> >> >> >> >> On Fri, Mar 16, 2012 at 12:37 PM, Francisco Caraballo >> <[email protected]> wrote: >>> Now I'm getting this error all over the place: >>> >>> error C2491: >>> 'google::protobuf::compiler::CodeGeneratorRequest::_default_parameter_' >>> : definition of dllimport static data member not allowed >>> >>> Saludos, >>> >>> Francisco Caraballo >>> >>> >>> >>> On Fri, Mar 16, 2012 at 5:10 PM, Utkarsh Ayachit >>> <[email protected]> wrote: >>>> In that case, just put the two attached files in the source tree as >>>> follows (ensure that you replace the exisiting files): >>>> >>>> PV.CMakeLists.txt ==> >>>> <ParaViewSource>/ParaViewCore/ServerImplementation/CMakeLists.txt >>>> PROTOBUF.CMakeLists.txt ==> >>>> <ParaViewSource>/Utilities/protobuf/src/CMakeLists.txt >>>> >>>> Utkarsh >>>> >>>> >>>> On Fri, Mar 16, 2012 at 12:04 PM, Francisco Caraballo >>>> <[email protected]> wrote: >>>>> I didn't originally get the code via git, so git checkout -f is not >>>>> working. Should I restore the whole Paraview 3.14 tree to what I >>>>> originally downloaded and then apply the new patches? >>>>> >>>>> Saludos/greetings, >>>>> >>>>> Francisco Caraballo >>>>> >>>>> >>>>> >>>>> On Fri, Mar 16, 2012 at 4:53 PM, Utkarsh Ayachit >>>>> <[email protected]> wrote: >>>>>> Better yet, can you try the attached patches please? What I've done is >>>>>> removed the dependency of protoc.exe on these unnecessary extra >>>>>> libraries making it possible to avoid such traps. >>>>>> >>>>>> Patch the files as follows (from ParaView Source Tree): >>>>>> >>>>>> # discard any changes from previous patches >>>>>>> git checkout -f >>>>>> >>>>>>> git apply paraview.patch >>>>>> >>>>>>> cd Utilities/protobuf >>>>>>> git apply protobuf.patch >>>>>> >>>>>> Hopefully, this should solve the issue. If all works, I'll push this >>>>>> to git and we can have these changes in the next release of ParaView. >>>>>> Thanks a lot for helping track this one down. >>>>>> >>>>>> Utkarsh >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Mar 16, 2012 at 11:43 AM, Francisco Caraballo >>>>>> <[email protected]> wrote: >>>>>>> This file in my computer is in C:\Program Files (x86)\zlib\bin. Should >>>>>>> I add this folder somewhere? >>>>>>> >>>>>>> Saludos, >>>>>>> >>>>>>> Francisco Caraballo >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Mar 16, 2012 at 4:35 PM, Utkarsh Ayachit >>>>>>> <[email protected]> wrote: >>>>>>>> Interesting. Where is it? Isn't it already in the ParaVIew build tree? >>>>>>>> >>>>>>>> Utkarsh >>>>>>>> >>>>>>>> On Fri, Mar 16, 2012 at 11:32 AM, Francisco Caraballo >>>>>>>> <[email protected]> wrote: >>>>>>>>> The DLL that is missing is zlibd1.dll >>>>>>>>> >>>>>>>>> Saludos/greetings, >>>>>>>>> >>>>>>>>> Francisco Caraballo >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, Mar 16, 2012 at 3:49 PM, Utkarsh Ayachit >>>>>>>>> <[email protected]> wrote: >>>>>>>>>> Ok. Next, can you try to locate protoc.exe under the ParaView build >>>>>>>>>> tree and manually run it? You may get some missing dlls errors and >>>>>>>>>> those are the ones we need to identify. In the mean time I'm going to >>>>>>>>>> try to see if we can build protoc.exe statically without any >>>>>>>>>> dependencies to ensure that it runs cleanly always. >>>>>>>>>> >>>>>>>>>> Utkarsh >>>>>>>>>> >>>>>>>>>> On Thu, Mar 15, 2012 at 8:55 PM, Francisco Caraballo >>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>> I applied it, ran cmake again from the beggining and tried building >>>>>>>>>>> again, but it didnt work, same error. >>>>>>>>>>> Is there any way I can validate the patch was applied correctly? I >>>>>>>>>>> did >>>>>>>>>>> it using <<git apply file.patch>> but it didnt print any success >>>>>>>>>>> message. >>>>>>>>>>> >>>>>>>>>>> Thanks a lot for all the help! >>>>>>>>>>> >>>>>>>>>>> Saludos/greetings, >>>>>>>>>>> >>>>>>>>>>> Francisco Caraballo >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Thu, Mar 15, 2012 at 10:34 PM, Utkarsh Ayachit >>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>> The problem is that a tool (namely, protoc.exe) isn't being run >>>>>>>>>>>> correctly to generate the needed files. Can you to apply the >>>>>>>>>>>> attached >>>>>>>>>>>> patch to see if that helps solve the problem? You'll have to apply >>>>>>>>>>>> it >>>>>>>>>>>> to the 3.14.0 source code. >>>>>>>>>>>> >>>>>>>>>>>> Utkarsh >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Mar 15, 2012 at 4:01 PM, Francisco Caraballo >>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>> I'm getting the same error with 3.14: >>>>>>>>>>>>> fatal error C1083: Cannot open include file: 'vtkPVMessage.pb.h': >>>>>>>>>>>>> No >>>>>>>>>>>>> such file or directory >>>>>>>>>>>>> >>>>>>>>>>>>> Saludos/greetings, >>>>>>>>>>>>> >>>>>>>>>>>>> Francisco Caraballo >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Mar 15, 2012 at 6:30 PM, Utkarsh Ayachit >>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>> sorry typo: I meant "unless using nmake -- which is the command >>>>>>>>>>>>>> line >>>>>>>>>>>>>> build mechanism for VS" >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 12:44 PM, Francisco Caraballo >>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>> I could try with 3.14, but I am using cmake. >>>>>>>>>>>>>>> What do you mean with "unless using cmake".That if I am using >>>>>>>>>>>>>>> cmake >>>>>>>>>>>>>>> 3.14 wont work either? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Saludos greetings, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Francisco Caraballo >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 5:25 PM, Utkarsh Ayachit >>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>> Any reason you're not using 3.14? I'm not sure if this is a >>>>>>>>>>>>>>>> known >>>>>>>>>>>>>>>> issue with 3.12, but we haven't seen this with 3.14 unless >>>>>>>>>>>>>>>> using >>>>>>>>>>>>>>>> cmake. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Utkarsh >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 12:20 PM, Francisco Caraballo >>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>> I build using the Visual Studio Express 2010 IDE >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Saludos, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Francisco Caraballo >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 4:46 PM, Utkarsh Ayachit >>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>> How do you build? Using the visual studio IDE or command >>>>>>>>>>>>>>>>>> line? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 11:33 AM, Francisco Caraballo >>>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>>> I generated the project files with Cmake. I'm not using >>>>>>>>>>>>>>>>>>> nmake, as far >>>>>>>>>>>>>>>>>>> as I know. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Saludos greetings, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Francisco Caraballo >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 3:40 PM, Utkarsh Ayachit >>>>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>>>> Is this with nmake? >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Utkarsh >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Thu, Mar 15, 2012 at 10:14 AM, Francisco Caraballo >>>>>>>>>>>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>>>>>>>>>>>> I get the following error when compiling Paraview 3.12 on >>>>>>>>>>>>>>>>>>>>> Visual >>>>>>>>>>>>>>>>>>>>> Studio Express 2010. >>>>>>>>>>>>>>>>>>>>> << fatal error C1083: Cannot open include file: >>>>>>>>>>>>>>>>>>>>> 'vtkPVMessage.pb.h': >>>>>>>>>>>>>>>>>>>>> No such file or directory >> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Following other messages on this mailing-list I gathered >>>>>>>>>>>>>>>>>>>>> that this has >>>>>>>>>>>>>>>>>>>>> something to do with Protobuf (whatever that is). So I >>>>>>>>>>>>>>>>>>>>> checked the >>>>>>>>>>>>>>>>>>>>> messages related to protobuf and found this message: >>>>>>>>>>>>>>>>>>>>> 4>------ Build started: Project: protobuf_code_generation, >>>>>>>>>>>>>>>>>>>>> Configuration: Release Win32 ------ >>>>>>>>>>>>>>>>>>>>> 4> Generating vtkPVMessage.pb.h, vtkPVMessage.pb.cc >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> So in theory the file should exist, but it doesnt. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Can anyone help me out with this? Is this a Paraview >>>>>>>>>>>>>>>>>>>>> problem, or a >>>>>>>>>>>>>>>>>>>>> Cmake problem, or a VS Express 2010 problem? >>>>>>>>>>>>>>>>>>>>> I'm compiling without MPI support (because that generates >>>>>>>>>>>>>>>>>>>>> a whole >>>>>>>>>>>>>>>>>>>>> other bunch of problems) could that have something to do >>>>>>>>>>>>>>>>>>>>> with my >>>>>>>>>>>>>>>>>>>>> problem? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Saludos/greetings, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Francisco Caraballo >>>>>>>>>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>>>>>>>>> Powered by www.kitware.com >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Visit other Kitware open-source projects at >>>>>>>>>>>>>>>>>>>>> http://www.kitware.com/opensource/opensource.html >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Please keep messages on-topic and check the ParaView Wiki >>>>>>>>>>>>>>>>>>>>> at: http://paraview.org/Wiki/ParaView >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Follow this link to subscribe/unsubscribe: >>>>>>>>>>>>>>>>>>>>> http://www.paraview.org/mailman/listinfo/paraview _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
