Just pushed a fix for this. Patch attached. Utkarsh
On Wed, Oct 29, 2014 at 8:51 PM, Scott, W Alan <[email protected]> wrote: > Jean, > > > > I just tried with PV 4.2.0, Linux Mesa (local server), Linux hardware > rendering, and my local Windows 7 box (Kitware download), and they all > worked with –stereo-type=Interlaced. At least I believe they worked, > nothing crashed and the image looked good. (Note that the command is > Interlaced, not interlace). Other than that, the only thing I can think of > is to delete your config files. > http://www.paraview.org/Wiki/ParaView_Settings_Files. > > > > Alan > > > > From: ParaView [mailto:[email protected]] On Behalf Of Jean > Hertzberg > Sent: Wednesday, October 29, 2014 5:07 PM > To: [email protected] > Subject: [EXTERNAL] [Paraview] 4.2.0 stereo interlace problem > > > > Hi. > > I have not been able to get PV 4.2.0 to work in stereo interlace mode on my > Windows 7 64 bit system. Default mode seems to be red-blue, and that works > fine, but I get this error on startup when I specify –stereo-type=Interlace > > > > ERROR: In > C:\DBD\pvs-x64\paraview\src\paraview\VTK\Rendering\OpenGL\vtkOpenGLCamera.cxx, > line 167 > > vtkOpenGLCamera (000000000B119790): failed after Render 1 OpenGL errors > detected > > 0 : (1282) Invalid operation > > > > PV 4.0.1 starts in interlace mode with no problem on the same system. > > Suggestions? I didn’t see any known bugs regarding this. > > > > Jean Hertzberg > > > > Dept. Mechanical Engineering > > University of Colorado, Boulder > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the ParaView Wiki at: > http://paraview.org/Wiki/ParaView > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/paraview >
From 0c9dfba005630fcbb6ce237a800157f0dcb7b60a Mon Sep 17 00:00:00 2001 From: Utkarsh Ayachit <[email protected]> Date: Fri, 31 Oct 2014 14:25:02 -0400 Subject: [PATCH] BUG #15093: Fixed issue with stereo rendering. The problem was that the StereoType set on vtkRenderWindow was incorrect. It ended up picking Crystal Eyes incorrectly. The problem was due to the the "StereoType" property being reset to default by vtkSMParaViewPipelineController. This fixes that. Also added tests to test setting of stereo modes to catch this in future. Change-Id: I20d7227d2059be007b8ff2d1a6abffa349679345 --- Applications/ParaView/Testing/XML/CMakeLists.txt | 33 ++++++++++++++++++++++ .../ParaView/Testing/XML/StereoInterlaced.xml | 22 +++++++++++++++ .../Testing/XML/StereoSplitViewportHorizontal.xml | 22 +++++++++++++++ .../Core/vtkSMParaViewPipelineController.cxx | 5 +++- .../Resources/views_and_representations.xml | 2 +- Testing/Data/Baseline/StereoInterlaced.png.md5 | 1 + .../Baseline/StereoSplitViewportHorizontal.png.md5 | 1 + 7 files changed, 84 insertions(+), 2 deletions(-) create mode 100644 Applications/ParaView/Testing/XML/StereoInterlaced.xml create mode 100644 Applications/ParaView/Testing/XML/StereoSplitViewportHorizontal.xml create mode 100644 Testing/Data/Baseline/StereoInterlaced.png.md5 create mode 100644 Testing/Data/Baseline/StereoSplitViewportHorizontal.png.md5 diff --git a/Applications/ParaView/Testing/XML/CMakeLists.txt b/Applications/ParaView/Testing/XML/CMakeLists.txt index 3449642..118b67f 100644 --- a/Applications/ParaView/Testing/XML/CMakeLists.txt +++ b/Applications/ParaView/Testing/XML/CMakeLists.txt @@ -736,4 +736,37 @@ if (TARGET paraview) --state=${CMAKE_CURRENT_BINARY_DIR}/exodusStateFile.3.14.1.pvsm BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/LoadExodusStateFile.xml) + + #---------------------------------------------------------------------- + # Add test to test stereo rendering modes. + add_client_tests("pv" + --stereo + --stereo-type=Interlaced + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoInterlaced.xml) + add_client_server_tests("pvcs" + --stereo + --stereo-type=Interlaced + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoInterlaced.xml) + add_client_render_server_tests("pvcrs" + --stereo + --stereo-type=Interlaced + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoInterlaced.xml) + add_client_tests("pv" + --stereo + --stereo-type=SplitViewportHorizontal + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoSplitViewportHorizontal.xml) + add_client_server_tests("pvcs" + --stereo + --stereo-type=SplitViewportHorizontal + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoSplitViewportHorizontal.xml) + add_client_render_server_tests("pvcrs" + --stereo + --stereo-type=SplitViewportHorizontal + BASELINE_DIR ${PARAVIEW_TEST_BASELINE_DIR} + TEST_SCRIPTS ${CMAKE_CURRENT_SOURCE_DIR}/StereoSplitViewportHorizontal.xml) endif() diff --git a/Applications/ParaView/Testing/XML/StereoInterlaced.xml b/Applications/ParaView/Testing/XML/StereoInterlaced.xml new file mode 100644 index 0000000..3bc81d8 --- /dev/null +++ b/Applications/ParaView/Testing/XML/StereoInterlaced.xml @@ -0,0 +1,22 @@ +<?xml version="1.0" ?> +<pqevents> + <pqevent object="pqClientMainWindow/menubar" command="activate" arguments="menuSources" /> + <pqevent object="pqClientMainWindow/menubar/menuSources" command="activate" arguments="SuperquadricSource" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/Accept" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/SearchBox/AdvancedButton" command="set_boolean" arguments="true" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/ThetaResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/ThetaResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/PhiResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/PhiResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/Accept" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/representationToolbar/displayRepresentation/comboBox" command="set_string" arguments="Surface With Edges" /> + <pqevent object="pqClientMainWindow/cameraToolbar/actionPositiveY" command="activate" arguments="" /> + + <pqevent object="pqClientMainWindow/menubar" command="activate" arguments="menuTools" /> + <pqevent object="pqClientMainWindow/menubar/menuTools" command="activate" arguments="actionTesting_Window_Size" /> + <pqevent object="pqClientMainWindow/cameraToolbar/actionResetCamera" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mousePress" arguments="(0.536667,0.53,2,2,0)" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mouseMove" arguments="(0.533333,0.7,2,0,0)" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mouseRelease" arguments="(0.533333,0.7,2,0,0)" /> + <pqevent object="pqClientMainWindow/representationToolbar/displayRepresentation/comboBox" command="set_string" arguments="Surface" /> +</pqevents> diff --git a/Applications/ParaView/Testing/XML/StereoSplitViewportHorizontal.xml b/Applications/ParaView/Testing/XML/StereoSplitViewportHorizontal.xml new file mode 100644 index 0000000..3bc81d8 --- /dev/null +++ b/Applications/ParaView/Testing/XML/StereoSplitViewportHorizontal.xml @@ -0,0 +1,22 @@ +<?xml version="1.0" ?> +<pqevents> + <pqevent object="pqClientMainWindow/menubar" command="activate" arguments="menuSources" /> + <pqevent object="pqClientMainWindow/menubar/menuSources" command="activate" arguments="SuperquadricSource" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/Accept" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/SearchBox/AdvancedButton" command="set_boolean" arguments="true" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/ThetaResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/ThetaResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/PhiResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/scrollArea/qt_scrollarea_viewport/scrollAreaWidgetContents/PropertiesFrame/ProxyPanel/PhiResolution/IntRangeWidget/LineEdit" command="set_string" arguments="32" /> + <pqevent object="pqClientMainWindow/propertiesDock/propertiesPanel/Accept" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/representationToolbar/displayRepresentation/comboBox" command="set_string" arguments="Surface With Edges" /> + <pqevent object="pqClientMainWindow/cameraToolbar/actionPositiveY" command="activate" arguments="" /> + + <pqevent object="pqClientMainWindow/menubar" command="activate" arguments="menuTools" /> + <pqevent object="pqClientMainWindow/menubar/menuTools" command="activate" arguments="actionTesting_Window_Size" /> + <pqevent object="pqClientMainWindow/cameraToolbar/actionResetCamera" command="activate" arguments="" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mousePress" arguments="(0.536667,0.53,2,2,0)" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mouseMove" arguments="(0.533333,0.7,2,0,0)" /> + <pqevent object="pqClientMainWindow/centralwidget/MultiViewWidget/CoreWidget/qt_tabwidget_stackedwidget/MultiViewWidget1/Frame.0/Viewport" command="mouseRelease" arguments="(0.533333,0.7,2,0,0)" /> + <pqevent object="pqClientMainWindow/representationToolbar/displayRepresentation/comboBox" command="set_string" arguments="Surface" /> +</pqevents> diff --git a/ParaViewCore/ServerManager/Core/vtkSMParaViewPipelineController.cxx b/ParaViewCore/ServerManager/Core/vtkSMParaViewPipelineController.cxx index 6c5e941..a1c897e 100644 --- a/ParaViewCore/ServerManager/Core/vtkSMParaViewPipelineController.cxx +++ b/ParaViewCore/ServerManager/Core/vtkSMParaViewPipelineController.cxx @@ -1098,7 +1098,10 @@ bool vtkSMParaViewPipelineController::PostInitializeProxy(vtkSMProxy* proxy) { vtkSMProperty* smproperty = iter->GetProperty(); - if ((smproperty->GetMTime() > ts) || smproperty->GetInformationOnly()) + if ((smproperty->GetMTime() > ts) || + smproperty->GetInformationOnly() || + // doesn't make sense to set property values for internal properties. + smproperty->GetIsInternal()) { // Property was modified between since the PreInitializeProxy() call. We // leave it untouched. diff --git a/ParaViewCore/ServerManager/SMApplication/Resources/views_and_representations.xml b/ParaViewCore/ServerManager/SMApplication/Resources/views_and_representations.xml index c08e69a..1eb773e 100644 --- a/ParaViewCore/ServerManager/SMApplication/Resources/views_and_representations.xml +++ b/ParaViewCore/ServerManager/SMApplication/Resources/views_and_representations.xml @@ -2049,7 +2049,7 @@ <BooleanDomain name="bool" /> </IntVectorProperty> <IntVectorProperty command="SetStereoType" - default_values="3" + default_values="none" name="StereoType" panel_visibility="never" number_of_elements="1" diff --git a/Testing/Data/Baseline/StereoInterlaced.png.md5 b/Testing/Data/Baseline/StereoInterlaced.png.md5 new file mode 100644 index 0000000..37191af --- /dev/null +++ b/Testing/Data/Baseline/StereoInterlaced.png.md5 @@ -0,0 +1 @@ +d3d7ed46b2f6807f33f7404defc8fbd2 diff --git a/Testing/Data/Baseline/StereoSplitViewportHorizontal.png.md5 b/Testing/Data/Baseline/StereoSplitViewportHorizontal.png.md5 new file mode 100644 index 0000000..000efec --- /dev/null +++ b/Testing/Data/Baseline/StereoSplitViewportHorizontal.png.md5 @@ -0,0 +1 @@ +be9928f2479342a6897ec3612cd06616 -- 1.9.1
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/paraview
