On Tue, Mar 10, 2015 at 1:13 PM, Utkarsh Ayachit <[email protected]> wrote: > Cool. John, can you please have the fix merged in VTK/ParaView? > > Ondrej, it seems that vtkIOGDAL module is not enabled in ParaView by > default. Did you enable it explicitly? That'd explain why it's not > failing on the dashboards.
Ah I see -- yes, we had '-DModule_vtkIOGDAL:BOOL=ON'. Robert created the initial script, here is what we use: https://github.com/hashdist/hashstack/blob/ac8ccec893e9e9ae6b9b6bbce0c6ed5541509d7e/pkgs/paraview/paraview.yaml And to fix it, I just added your patch in, as follows: diff --git a/pkgs/paraview/FixGDAL.patch b/pkgs/paraview/FixGDAL.patch new file mode 100644 index 0000000..4ed413d --- /dev/null +++ b/pkgs/paraview/FixGDAL.patch @@ -0,0 +1,13 @@ +diff --git a/IO/GDAL/CMakeLists.txt b/IO/GDAL/CMakeLists.txt +index 9cb8fe6..eb1b582 100644 +--- a/IO/GDAL/CMakeLists.txt ++++ b/IO/GDAL/CMakeLists.txt +@@ -4,7 +4,7 @@ mark_as_advanced(GDAL_INCLUDE_DIR GDAL_LIBRARY) + set(GDAL_SRCS vtkGDAL.cxx vtkGDALVectorReader.cxx vtkGDALRasterReader.cxx) + + include_directories(${GDAL_INCLUDE_DIRS}) +-set_source_files_properties(vtkGDAL.h WRAP_EXCLUDE) ++set_source_files_properties(vtkGDAL WRAP_EXCLUDE) + + vtk_module_library(vtkIOGDAL ${GDAL_SRCS}) + diff --git a/pkgs/paraview/paraview.yaml b/pkgs/paraview/paraview.yaml index e05a7cb..4cba6ff 100644 --- a/pkgs/paraview/paraview.yaml +++ b/pkgs/paraview/paraview.yaml @@ -5,7 +5,7 @@ dependencies: python, numpy, matplotlib, libxml2, {{build_with}}] sources: -- key: git:f7aac037722d9d13b75d9fdb15a1053c0874c6c6 +- key: git:0a4ad038370beb6d30f51f43e32555b3adcea123 url: https://github.com/Kitware/ParaView.git defaults: @@ -20,6 +20,13 @@ build_stages: bash: | patch -up1 < _hashdist/installGenerateFiles.patch +- name: patch5 + before: configure + files: [FixGDAL.patch] + handler: bash + bash: | + (cd VTK; patch -up1 < ../_hashdist/FixGDAL.patch) + - name: configure mode: override extra: [ I'll wait until you fix it in VTK and update the VTK submodule in Paraview, and then just use the latest git master. But the above fixes it. Thanks again for figuring it out so quickly. Ondrej _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Search the list archives at: http://markmail.org/search/?q=ParaView Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/paraview
