(cc-ing the correct, Mark this time :)).

Thanks, Mark/Christoph. I think I know what's causing the VTKm version issue.

Can you try the attached patches? The VTKm one has to be applied under
ParaView/VTK/ThirdParty/vtkm/vtk-m/.

Utkarsh



> On Sat, Apr 21, 2018 at 7:28 PM, Christoph Grüninger <[email protected]> 
> wrote:
>> Hi Utkarsh,
>> please find attached the full log, including the error message.
>>
>> Building the examples is now disabled.
>>
>> Bye
>> Christoph
>>
>>
>> Am 16.04.2018 um 18:14 schrieb Utkarsh Ayachit:
>>> Christoph,
>>>
>>> I am totally unfamiliar with OpenSUSE and my initial attempts to even
>>> install a C++ compiler are going no where :). Mind making it easier
>>> for me and just post the full error message that you're getting? Maybe
>>> attaching the 
>>> /home/abuild/rpmbuild/BUILD/ParaView-v5.5.0/build/VTK/ThirdParty/vtkm/vtk-m/lib/cmake/paraview-5.5/vtkm/VTKmConfig.cmake
>>> file will throw some light. Also is this failing when building the
>>> Examples or just ther full ParaView build? I'd suggest disabling
>>> examples, if that's the issue. The ParaView RPM should probably not
>>> include examples any ways.
>>>
>>> Utkarsh
From cf7268335b63632048bc2e9866715901b653fc9a Mon Sep 17 00:00:00 2001
From: Utkarsh Ayachit <[email protected]>
Date: Sun, 22 Apr 2018 20:26:35 -0400
Subject: [PATCH] fixes issues with ParaViewDetermineVersion.

The code had 2 issues:
1. used obsolete 'output' if Git executable was missing. There was a
   possibility that output variable was never set and used some garbage
   value from parent scope.

2. version pattern matching was too liberal and would match absolute
   any long txt so long as it has some numbers in it that matched a
   typical version number.
---
 CMake/ParaViewDetermineVersion.cmake | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/CMake/ParaViewDetermineVersion.cmake b/CMake/ParaViewDetermineVersion.cmake
index 41e67a0..75eb3ad 100644
--- a/CMake/ParaViewDetermineVersion.cmake
+++ b/CMake/ParaViewDetermineVersion.cmake
@@ -45,6 +45,8 @@ function(determine_version source_dir git_command var_prefix)
         ERROR_QUIET
         OUTPUT_STRIP_TRAILING_WHITESPACE
         ERROR_STRIP_TRAILING_WHITESPACE)
+    else()
+      set(output)
     endif()
   else()
     set(result 0)
@@ -65,7 +67,7 @@ endfunction()
 
 # Extracts components from a version string. See determine_version() for usage.
 function(extract_version_components version_string var_prefix)
-  string(REGEX MATCH "([0-9]+)\\.([0-9]+)\\.([0-9]+)[-]*(.*)"
+  string(REGEX MATCH "^([0-9]+)\\.([0-9]+)\\.([0-9]+)[-]*(.*)$"
     version_matches "${version_string}")
   if(CMAKE_MATCH_0)
     set(full ${CMAKE_MATCH_0})
-- 
2.7.4

From f41519f9691d254e5734fb7651bbad5dc6a1fda3 Mon Sep 17 00:00:00 2001
From: Utkarsh Ayachit <[email protected]>
Date: Sun, 22 Apr 2018 20:29:18 -0400
Subject: [PATCH] Fix issues with VTKmDetermineVersion.

The code had 2 issues:
1. used obsolete 'output' if Git executable was missing. There was a
   possibility that output variable was never set and used some garbage
   value from parent scope.

2. version pattern matching was too liberal and would match
   absolute any long txt so long as it has some numbers in it that matched
   a typical version number.
---
 CMake/VTKmDetermineVersion.cmake | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/CMake/VTKmDetermineVersion.cmake b/CMake/VTKmDetermineVersion.cmake
index 7b990be..92ffd94 100644
--- a/CMake/VTKmDetermineVersion.cmake
+++ b/CMake/VTKmDetermineVersion.cmake
@@ -51,6 +51,8 @@ function(determine_version source_dir git_command var_prefix)
         ERROR_QUIET
         OUTPUT_STRIP_TRAILING_WHITESPACE
         ERROR_STRIP_TRAILING_WHITESPACE)
+    else()
+      set(output)
     endif()
   else()
     set(result 0)
@@ -75,7 +77,7 @@ endfunction()
 
 # Extracts components from a version string. See determine_version() for usage.
 function(extract_version_components version_string var_prefix)
-  string(REGEX MATCH "([0-9]+)\\.([0-9]+)\\.([0-9]+)[-]*(.*)"
+  string(REGEX MATCH "^([0-9]+)\\.([0-9]+)\\.([0-9]+)[-]*(.*)$"
     version_matches "${version_string}")
   if(CMAKE_MATCH_0)
     set(full ${CMAKE_MATCH_0})
-- 
2.7.4

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Search the list archives at: http://markmail.org/search/?q=ParaView

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/paraview

Reply via email to