Branch: refs/heads/eliminate_multi
Home: https://github.com/parrot/parrot
Commit: f4a2ff1c36a2af16150f9c507836e7237200e950
https://github.com/parrot/parrot/commit/f4a2ff1c36a2af16150f9c507836e7237200e950
Author: jkeenan <[email protected]>
Date: 2012-06-09 (Sat, 09 Jun 2012)
Changed paths:
M lib/Parrot/Pmc2c/MULTI.pm
M lib/Parrot/Pmc2c/Parser.pm
Log Message:
-----------
Parrot::Pmc2c::MULTI::rewrite_multi_sub() is invoked only once, in
Parrot::Pmc2c::Parser::find_methods(). The way it is written would lead one
to believe that its first argument was an object of its own class, which it is
not. The first argument is a Parrot::Pmc2c::Method object. So inside
rewrite_multi_sub(), rename $self -> $method to be more self-documenting.
Commit: 2ad68dd6d47c90a40afec07304e1150f4a63542f
https://github.com/parrot/parrot/commit/2ad68dd6d47c90a40afec07304e1150f4a63542f
Author: jkeenan <[email protected]>
Date: 2012-06-09 (Sat, 09 Jun 2012)
Changed paths:
M lib/Parrot/Pmc2c/PCCMETHOD.pm
M lib/Parrot/Pmc2c/Parser.pm
Log Message:
-----------
Parrot::Pmc2c::MULTI::rewrite_pccmethod() and mangle_name() are invoked only
once each, in Parrot::Pmc2c::Parser::find_methods(). The way they are written
would lead one to believe that their first arguments were objects of the
Parrot::Pmc2c::MULTI class, which they are not. In each case, the first
argument is a Parrot::Pmc2c::Method object. So inside rewrite_multi_sub(),
rename $self -> $method to be more self-documenting.
In addition, mangle_name() makes no use of its second argument, $pmc. So
eliminate it.
Commit: a4ffcce82820ad8073087eeb64aa2e2b5f81ea96
https://github.com/parrot/parrot/commit/a4ffcce82820ad8073087eeb64aa2e2b5f81ea96
Author: jkeenan <[email protected]>
Date: 2012-06-09 (Sat, 09 Jun 2012)
Changed paths:
M MANIFEST
R lib/Parrot/Pmc2c/MULTI.pm
M lib/Parrot/Pmc2c/PCCMETHOD.pm
M lib/Parrot/Pmc2c/Parser.pm
Log Message:
-----------
Parrot::Pmc2c::MULTI::rewrite_multi_sub() is invoked only once, inside
Parrot::Pmc2c::Parser::find_methods. Let's move it to Parrot::Pmc2c::PCCMETHOD
where it can reside along two other subroutines invoked within find_methods.
This enables us to eliminate lib/Parrot/Pmc2c/MULTI.pm entirely.
Compare: https://github.com/parrot/parrot/compare/f4a2ff1^...a4ffcce
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-commits
