Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: 5f2468d43ab74f4f472ea52cf55b55a419205c1d
      
https://github.com/parrot/parrot/commit/5f2468d43ab74f4f472ea52cf55b55a419205c1d
  Author: James E Keenan <[email protected]>
  Date:   2025-11-29 (Sat, 29 Nov 2025)

  Changed paths:
    M config/auto/perldoc.pm
    M config/gen/config_pm.pm
    M config/init/defaults.pm
    M config/inter/libparrot.pm

  Log Message:
  -----------
  Use consistent syntax for import of File::Spec functions

Heretofore in Perl modules underneath config/, some File::Spec
functionality was imported as methods and some as functions.

  $ ack 'use File::Spec' config
  config/inter/libparrot.pm
  21:use File::Spec ();

  config/auto/perldoc.pm
  23:use File::Spec qw (catfile );

  config/auto/pmc.pm
  21:use File::Spec::Functions qw/catfile/;

  config/init/defaults.pm
  27:use File::Spec;

  config/init/hints.pm
  19:use File::Spec::Functions qw/catfile/;

  config/gen/config_pm.pm
  24:use File::Spec::Functions qw(catdir);

In the case of config/auto/perldoc, we use-d File::Spec but followed
that with an argument, as if we had intended to use
File::Spec::Functions.  In recent versions of Perl that gives a warning:

  Attempt to call undefined import method with arguments ("catfile") via
  package "File::Spec" (Perhaps you forgot to load the package?) at
  config/auto/perldoc.pm line 23.

.. which will eventually become an exception.

This commit standardizes the way we import and call such functionality.


  Commit: d395d9ed7f189da6207177e7c0f7160565efcfdc
      
https://github.com/parrot/parrot/commit/d395d9ed7f189da6207177e7c0f7160565efcfdc
  Author: James E Keenan <[email protected]>
  Date:   2025-11-29 (Sat, 29 Nov 2025)

  Changed paths:
    M config/auto/byteorder.pm

  Log Message:
  -----------
  Remove superfluous import.

When using recent versions of Perl to run Configure.pl, the line deleted
was generating this warning (which is scheduled to become an exception):

  Attempt to call undefined import method with arguments (":auto") via
  package "Parrot::Configure::Step" (Perhaps you forgot to load the
  package?) at config/auto/byteorder.pm line 18.

It appears the entire statement can simply be removed.


  Commit: 0106b1929bdcf6194ffc7d9a202f3b7ce86f4503
      
https://github.com/parrot/parrot/commit/0106b1929bdcf6194ffc7d9a202f3b7ce86f4503
  Author: Reini Urban <[email protected]>
  Date:   2025-11-29 (Sat, 29 Nov 2025)

  Changed paths:
    M config/auto/byteorder.pm
    M config/auto/perldoc.pm
    M config/gen/config_pm.pm
    M config/init/defaults.pm
    M config/inter/libparrot.pm

  Log Message:
  -----------
  Merge pull request #1251 from jkeenan/config-touchups-20251129

Touchups to code in config/*/*.pm modules


Compare: https://github.com/parrot/parrot/compare/c355501677ae...0106b1929bdc

To unsubscribe from these emails, change your notification settings at 
https://github.com/parrot/parrot/settings/notifications
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-commits

Reply via email to