Applied in r33923. In future, it's probably best to open a trac ticket, even for small patches like this. Hopefully we'll get an email alias in place to open tickets to reduce the overhead.
Thanks for keeping us honest. =-) On Thu, Dec 11, 2008 at 9:51 AM, Andrew Dougherty <[email protected]> wrote: > The 'string_free' function is also used in class.pmc, so it needs to be > visible outside src/string.c. How to do that, while still declaring it > as "inline" runs into a morass of linkage issues. (It's complicated > by the fact that the Configure.pl test and the PARROT_INLINE test in > <parrot/feature.h> don't test the same thing, and neither tests the > actual behavior that is actually used.) It's likely that most gcc-users > won't be affected at all, since PARROT_INLINE probably gets defined to > the empty string anyway for them. > > Probably easiest is to just to avoid the problem entirely for now. > > --- src/string.c 2008-12-11 09:20:48.000000000 -0500 > +++ src/string.c.new 2008-12-11 09:41:37.000000000 -0500 > @@ -247,7 +247,6 @@ > > */ > > -PARROT_INLINE > void > string_free(PARROT_INTERP, ARGIN(STRING *s)) > { > > -- > Andy Dougherty [email protected] > _______________________________________________ > http://lists.parrot.org/mailman/listinfo/parrot-dev > -- Will "Coke" Coleda _______________________________________________ http://lists.parrot.org/mailman/listinfo/parrot-dev
