On Friday 06 February 2009 05:05:39 [email protected] wrote:

> Author: rurban
> Date: Fri Feb  6 13:05:37 2009
> New Revision: 36401
> URL: https://trac.parrot.org/parrot/changeset/36401
>
> Log:
> Fix TT #279, report correct sourcefile line numbers
> with makefile compiler errors, and a test for it.

> Modified: trunk/t/steps/gen_makefiles-01.t
> ===========================================================================
> --- trunk/t/steps/gen_makefiles-01.t  Fri Feb  6 07:42:45 2009        (r36400)
> +++ trunk/t/steps/gen_makefiles-01.t  Fri Feb  6 13:05:37 2009        
> (r36401) @@
> @@ -155,7 +152,25 @@
>      }
>  }
>
> +# TT #279: reporting the makefile line number
> +# step gen::makefiles died during execution:
> +#  invalid op "IF" in "#IF(bla)" at "(bla)" at Configure.pl line 72
> +open IN, ">", "Makefile_$$.in";
> +print IN "# Test reporting sourcefile line numbers. TT #279\n";
> +print IN "#IF(IF(bla)):test\n";
> +close IN;

This part will likely trip a Perl::Critic policy which prohibits the use of 
global filehandles.

-- c
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to