I've removed "step 5" from the build factory. The real test is to see
if step 4 shows as failing when a unit test fails even though the
smoke report is sent successfully.
Sent from my iPhone
On Mar 3, 2009, at 1:25 PM, Reini Urban <[email protected]> wrote:
2009/3/2 Michael Peters <[email protected]>:
Matisse Enzer wrote:
It does do this. Right now I have 5 build steps defined:
1: ['/usr/bin/svn', 'checkout', '--revision', '37076',
'--non-interactive', 'https://svn.parrot.org/parrot/trunk', 'build']
That should just pull the latest revision
2: ['perl', 'Configure.pl']
3: ['make']
4: ['make', 'smoke']
For some reason I though that "make smoke" now sent the results to
smolder.
But looking at the Makefile that doesn't appear to be the case. Can
you
change that to ['make', 'smolder_test'] instead?
5: ['grep', 'ok, 0 failed,', './smoke.html']
That last one, #5, is a hack, to find out if the build as a whole
was
successful.
make smoke does not generate a ./smoke.html anymore as it used to
do a few weeks ago.
Yeah, that's an ugly hack and it won't work for "make
smolder_test". The
attached patch for t/harness should allow "make smoke" to return a
non-zero
exit status when a test fails, so you don't even need #5.
You can skip step 5
or just check the exit status of step 4 as suggested by michael.
--
Reini Urban
http://phpwiki.org/ http://murbreak.at/
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev
