Joshua Hoblitt wrote:
> Building Parrot for the first time in _way to long_ today, I noticed this
> compiler warning:
> 
>     compilers/imcc/pbc.c:182: warning: 'old_blocks' declared 'static' but 
> never defined
> 
> Which bothered me.  It looks like in pbc.c there are prototypes for
> old_blocks() declared twice.  One at line 182 and then again identically about
> 100 lines lower inside a #ifdef HAS_JIT.  old_block() itself also lives inside
> of another #ifdef HAS_JIT.  Is there any good reason not to remove the
> prototype that sits outside the HAS_JIT ifdefs?

Yeah.  The stuff in the block delimited by "HEADERIZER BEGIN" and
"HEADERIZER END" is autogenerated by "make headerizer", and headerizer
isn't smart enough (yet) to understand #ifdefs.  So if you fix it, it
will just come back the next time someone runs the headerizer.

I don't know if this has a ticket (yet), but I've mentioned it to Andy
Lester (the author of headerizer) on at least one occasion.

Mark

_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to