[email protected] schrieb:
Author: jkeenan
Date: Sat May  2 12:45:50 2009
New Revision: 38446
URL: https://trac.parrot.org/parrot/changeset/38446

Log:
Corrected the faulty logic described in
https://trac.parrot.org/parrot/ticket/586.
Replaced $_ with named lexicals in many locations.
Removed pirc and pirc.exe from MANIFEST.generated.
Removed one comment which referred to a ticket which was earlier rejected.

# TT #347
# 1. skip build_dir-only binaries for @installable_exe
for my $iref (@installable_exe) {

I wrote this.
Your fix from TT#586 just fixed a simple error in the 2nd loop (no logic), but deleting the comment for the first loop is not a good idea. The failure with installable_pirc e.g. was good, because the wrong MANIFEST.generated was detected.

But there are still more unfixed errors in MANIFEST.generated.
It would be nice if those errors could also be checked in the
installer, as nobody found or fixed it yet.

--- origsrc/parrot-1.1.0/MANIFEST.generated 2009-04-21 21:21:20.000000000 +0200
+++ src/parrot-1.1.0/MANIFEST.generated 2009-04-25 09:39:13.218750000 +0200
@@ -7,6 +7,8 @@ blib/lib/libparrot.a
 blib/lib/libparrot.dylib                          [main]lib
 blib/lib/libparrot.so.1.1.0                       [main]lib
 blib/lib/libparrot.so                             [main]lib
+cygparrot1_1_0.dll                                [main]bin
+libparrot.dll.a                                   [main]lib
 compilers/json/JSON/grammar.pbc                   [json]
 compilers/json/JSON.pbc                           [json]
 compilers/json/JSON/pge2pir.pbc                   [json]
@@ -46,6 +48,8 @@ include/parrot/platform.h
 include/parrot/platform_interface.h               [main]include
 include/parrot/platform_limits.h                  [devel]include
 include/parrot/vtable.h                           [main]include
+install_config.o                                  [devel]src
+install_config.obj                                [devel]src
 install_config.fpmc                               [main]lib
 installable_parrot_config.exe                     [main]bin
 installable_parrot_config                         [main]bin
@@ -57,8 +61,6 @@ installable_pbc_disassemble.exe
 installable_pbc_disassemble                       [main]bin
 installable_pbc_dump.exe                          [main]bin
 installable_pbc_dump                              [main]bin
-installable_pbc_info.exe                          [main]bin
-installable_pbc_info                              [main]bin
 installable_pbc_merge.exe                         [main]bin
 installable_pbc_merge                             [main]bin
 installable_pbc_to_exe.exe                        [main]bin
@@ -73,8 +75,6 @@ pbc_disassemble.exe
 pbc_disassemble                                   [main]bin
 pbc_dump.exe                                      [main]bin
 pbc_dump                                          [main]bin
-pbc_info.exe                                      [main]bin
-pbc_info                                          [main]bin
 pbc_merge.exe                                     [main]bin
 pbc_merge                                         [main]bin
 pbc_to_exe.exe                                    [main]bin
@@ -147,11 +147,16 @@ runtime/parrot/include/warnings.pasm
 runtime/parrot/library/CGI/QueryHash.pbc          [main]
 runtime/parrot/library/config.pbc                 [main]
 runtime/parrot/library/config.pir                 [main]
+runtime/parrot/library/Config/JSON.pbc            [main]
+runtime/parrot/library/Crow.pbc                   [main]
 runtime/parrot/library/Data/Dumper/Base.pbc       [main]
 runtime/parrot/library/Data/Dumper/Default.pbc    [main]
 runtime/parrot/library/Data/Dumper.pbc            [main]
+runtime/parrot/library/Data/Replace.pbc           [main]
+runtime/parrot/library/Digest/MD5.pbc             [main]
 runtime/parrot/library/dumper.pbc                 [main]
 runtime/parrot/library/Getopt/Obj.pbc             [main]
+runtime/parrot/library/libpcre.pbc                [main]
 runtime/parrot/library/Math/Random/mt19937ar.pbc  [main]
 runtime/parrot/library/Math/Rand.pbc              [main]
 runtime/parrot/library/MIME/Base64.pbc            [main]
@@ -177,7 +182,9 @@ runtime/parrot/library/PGE.pbc
 runtime/parrot/library/PGE/Perl6Grammar.pbc       [main]
 runtime/parrot/library/PGE/Text.pbc               [main]
 runtime/parrot/library/PGE/Util.pbc               [main]
+runtime/parrot/library/postgres.pbc               [main]
 runtime/parrot/library/Protoobject.pbc            [main]
+runtime/parrot/library/STM.pbc                    [main]
 runtime/parrot/library/Stream/Base.pbc            [main]
 runtime/parrot/library/Stream/Combiner.pbc        [main]
 runtime/parrot/library/Stream/Coroutine.pbc       [main]
@@ -187,12 +194,24 @@ runtime/parrot/library/Stream/ParrotIO.p
 runtime/parrot/library/Stream/Replay.pbc          [main]
 runtime/parrot/library/Stream/Sub.pbc             [main]
 runtime/parrot/library/Stream/Writer.pbc          [main]
+runtime/parrot/library/Test/Builder/Output.pbc    [main]
+runtime/parrot/library/Test/Builder/Test.pbc      [main]
+runtime/parrot/library/Test/Builder/Tester.pbc    [main]
+runtime/parrot/library/Test/Builder/TestPlan.pbc  [main]
+runtime/parrot/library/Test/Builder.pbc           [main]
+runtime/parrot/library/Test/Class.pbc             [main]
+runtime/parrot/library/Test/More.pbc              [main]
+runtime/parrot/library/Tcl/Glob.pbc               [main]
+runtime/parrot/library/uuid.pbc                   [main]
+runtime/parrot/library/yaml_dumper.pbc            [main]
+runtime/parrot/library/YAML/Parser/Syck.pbc       [main]
 runtime/parrot/library/TGE.pbc                    [tge]
 src/call_list.txt                                 [devel]src
 src/glut_callbacks.c                              []
 src/jit_emit.h                                    []
-src/nci.c                                         []
+src/nci.c                                         [devel]src
 src/null_config.c                                 []
+src/null_config.o                                 [devel]src
 src/ops/core_ops_cgp.c                            []
 src/ops/core_ops_switch.c                         []
 src/parrot_config.c                               []
@@ -226,5 +245,6 @@ src/pmc/string.dump
 src/pmc/sub.dump                                  [devel]src
 src/pmc/undef.dump                                [devel]src
 src/string_private_cstring.h                      []
-tools/build/dynpmc.pl                             []
-vtable.dump                                       [devel]src
+tools/build/dynpmc.pl                             [devel]
+tools/build/dynoplibs.pl                          [devel]
+vtable.dump                                       [devel]


--
Reini Urban
http://phpwiki.org/  http://murbreak.at/
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to