Will Coleda wrote:
I wrote a program (tools/dev/branch_status.pl) to give us some summary
information about existing branches, and put the output up at


Coke:

This was not passing t/codingstd/perlcritic.t. However, by applying the following patch, I was able to get it to pass:

Index: tools/dev/branch_status.pl
===================================================================
--- tools/dev/branch_status.pl  (revision 38625)
+++ tools/dev/branch_status.pl  (working copy)
@@ -8,11 +8,9 @@

 =cut

-## Modern::Perl (doesn't pass perlcritic)
-use 5.010_000;
+use v5.10.0;
 use strict;
 use warnings;
-use feature();

 use XML::Twig;
 use Perl6::Form;

I think this is more a bug in Perl::Critic than in perlcritic.t. Cf.: https://rt.cpan.org/Ticket/Display.html?id=45892.

I could not completely test this fix, however, because I was unable to install XML::Twig on either Linux or Darwin. That, in turn, was not a problem in XML::Twig, but an inability to install XML::Parser v2.36 on either OS!

Can you verify that my fix does not breach branch_status.pl?

Thank you very much.
kid51

_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to