On Monday 13 July 2009 16:27:13 Patrick R. Michaud wrote: > On Tue, Jul 14, 2009 at 09:06:50AM +1000, Vasily Chekalkin wrote:
> > Vasily Chekalkin wrote: > >> Ok, after many iterations and rumbling around I want to apply next > >> patch to Parrot. > > > > No objections? > > IMO, the patch is a significant enough change that we really ought > to see positive approval of the patch from people who understand > the consequences rather than simply "nobody objected". Especially > less than 10 days before a "supported release". > > I'm not a person that understands the consequences of the patch > nor the constants pool, thus I haven't commented on it (except for > this message). But it does sound to me like we should be looking > for "definitive positive review" more than "no negative reviews". I think it's the right approach. I have little hope that we'll be able to teach extenders how to deal with all of the constant PMCs appropriately. Constant STRINGs are a different problem; we can keep that pool with fewer gyrations. -- c _______________________________________________ http://lists.parrot.org/mailman/listinfo/parrot-dev
