On Mon May 14 04:33:54 2007, codermattie wrote: > Hello, > > This is a patch, and two new files: > > parrot/include/path.h > src/path.c > > These changes move the static path handling utilities out of library.c > into their own translation unit. > This allows all of the parrot code to use a single implementation of > common path handling functions. > > slight modifications were made to the win32 specific portions that > need to be re-tested on that > platform. > > I modified the config/gen/makefiles/root.in to get it compiling > properly , but I might have missed > something as this is my first change to the makefile. > > I get two harness failures I haven't figured out yet: > > t/op/sprintf.....................................ok 1/308parrot: > src/string.c:727: string_str_index: Assertion `s->encoding && > s->charset && !(((s)->obj.flags) & b_PObj_on_free_list_FLAG)' failed. > > This may be because I modified the functions in path.c to use more of > the string API instead of > bypassing it. Someone else may be able to decode this assertion > failure so I can pinpoint > where it is coming from. I suspect that it is coming from path.c:217 . > > In fact that entire function needs to be reviewed, I don't have the > unicode experience > to understand it's string manipulation. beyond the change on 217 I > haven't touched > that code with a cleanup yet. > > # Failed test (t/perl/Parrot_IO.t at line 159) > t/perl/Parrot_IO.................................NOK 51/57# Looks like > you failed 1 test of 57. > > This one I don't get at all. This could be random. > > Other than those two failures the test-suite passed on i686-pc-gnu- > linux > > Failed Test Stat Wstat Total Fail List of Failed > --------------------------------------------------------------------- ---------- > t/op/sprintf.t 0 6 308 234 192-308 > t/perl/Parrot_IO.t 1 256 57 1 51 > 9 tests and 512 subtests skipped. > Failed 2/304 test scripts. 118/7217 subtests failed. > Files=304, Tests=7217, 575 wallclock secs (288.14 cusr + 46.41 csys = > 334.55 CPU) > Failed 2/304 test programs. 118/7217 subtests failed. > > Cheers, > Mike Mattie >
Very sorry about the delay, but this patch no longer applies cleanly to trunk. If you'd care to rebase and resubmit the ticket to trac (https://trac.parrot.org/), hopefully we can provide better turnaround time going forward. Regards. -- Will "Coke" Coleda _______________________________________________ http://lists.parrot.org/mailman/listinfo/parrot-dev
