I have briefly looked over this patch.

* Why are you using a PMC when it is very clear that nothing but an
INTVAL is acceptable?
* I'm not a fan of the long-winded justification in
config/gen/platform/platform_interface.h. Document what the function
does, including a short statement to the effect that the second
argument provides access to non-default linker functionality.

Other than that, this looks pretty good to me.
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to