Determining whether a float is a special value or not seems like an important core operation so I think it should definitely go in src/ops/math.ops for now. Making it a dynop isn't worthwhile (and yes, we don't really have a clear policy for what goes where, yet. We can argue about that later).
The ops2c test that counts the exact number of ops has been removed in my pcc_ops branch, which I hope to merge sometime this week. If you want to similarly disable it in master that would be fine by me. Testing for the exact number of ops, considering how in flux our opset is, is a pointless exercise. --Andrew Whitworth On Tue, Dec 6, 2011 at 5:35 AM, Vasily Chekalkin <[email protected]> wrote: > On Tue, Dec 6, 2011 at 9:28 PM, Moritz Lenz <[email protected]> wrote: >>> And yes, tests are welcome with patch :) >> >> >> Sure thing :-) > > JFYI, there is few ops2c tests which are depends on exact number of > ops. They are failing with your patch. Not a big deal. > > -- > Bacek > _______________________________________________ > http://lists.parrot.org/mailman/listinfo/parrot-dev _______________________________________________ http://lists.parrot.org/mailman/listinfo/parrot-dev
