Yes looks good. Merge it.

--Andrew Whitworth
(Sent from my phone. Forgive terseness and misspelling)
On Aug 28, 2012 2:05 AM, "Jonathan "Duke" Leto" <[email protected]> wrote:

> Howdy,
>
> > And you would need to "pin" the pointer for the gc, not to move it.
> > If we would use a moving or copying gc somewhen.
> > Same problem as with ffi callbacks.
>
> I don't think so. I don't care too much about what get_pointer returns,
> just
> that it *does* return something and is a valid API call. I just added some
> extend_vtable tests and they pass:
>
>
> https://github.com/parrot/parrot/commit/ab4fd23d68101d4c5652eee835356128528ec792
>
> Does this diff look reasonable to merge?
>
> https://github.com/parrot/parrot/compare/leto/get_pointer
>
> Duke
>
>
> --
> Jonathan "Duke" Leto <[email protected]>
> Leto Labs LLC http://labs.leto.net
> 209.691.DUKE http://dukeleto.pl
> _______________________________________________
> http://lists.parrot.org/mailman/listinfo/parrot-dev
>
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to