#385: t/pmc/packfileconstanttable.t failure
--------------------+-------------------------------------------------------
Reporter: coke | Owner: Infinoid
Type: bug | Status: new
Priority: normal | Milestone:
Component: none | Version:
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
--------------------+-------------------------------------------------------
Comment(by Infinoid):
Replying to [comment:12 rg]:
> (I hope you agree that putting this patch inline is actually easier to
use)
(A normal attachment is easier for me to import into my patch stack, but I
can make it work either way.)
Thanks, you're right that keys aren't handled properly and that they
should be. However, it still isn't the full solution, as the tests should
generate their own pbc files to test against. (And those test files
should include some keys, of course.) Currently relying on random library
pbcs (which can be validly changed for other reasons) makes the tests
brittle, and it also means we can't test specific attributes like the
number of opcodes and the pbc version number and things like this. These
tests were a good starting point for verifying my code works, but their
coverage is poor and I need to improve them quite a bit.
> Could somebody a lot more knowledgeable with Parrot and Keys please
check if that's really the whole problem? FWIW it's not breaking make test
and fixing the given problem for me.
Yes, that's the whole problem, your patch brings the method in line with
what pdd13 specifies. But to me all of this stuff just points to the
larger issue of needing better (more targeted) testing, which is why I
want to leave this ticket open until I've dealt with that issue.
Mark
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/385#comment:13>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
