#446: [CAGE] Fixed a few warnings and a NCI example on Windows using MSVS
-------------------+--------------------------------------------------------
Reporter: ujwal | Type: cage
Status: new | Priority: normal
Milestone: | Component: configure
Version: trunk | Severity: medium
Keywords: | Lang:
Patch: new | Platform: win32
-------------------+--------------------------------------------------------
Comment(by rurban):
I have more msvc warnings. Two look important:
{{{
src/thread.c(503): Parrot_Interp interp =
(Parrot_Interp)VTABLE_get_pointer(interp, self);
'interp' used without having been initialized
}}}
and here we miss an explicit double => long cast:
{{{
--- src/key.c (revision 37431)
+++ src/key.c (working copy)
@@ -341,10 +341,10 @@
return REG_INT(interp, int_key);
case KEY_number_FLAG:
- return PMC_num_val(key);
+ return (INTVAL)PMC_num_val(key);
case KEY_number_FLAG | KEY_register_FLAG:
GETATTR_Key_int_key(interp, key, int_key);
- return REG_NUM(interp, int_key);
+ return (INTVAL)REG_NUM(interp, int_key);
case KEY_pmc_FLAG | KEY_register_FLAG:
{
}}}
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/446#comment:2>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
