#480: [PATCH] Display assembly filenames when compiling, like C filenames are
--------------------+-------------------------------------------------------
Reporter: wiml | Owner: jkeenan
Type: patch | Status: assigned
Priority: normal | Milestone:
Component: none | Version: trunk
Severity: low | Keywords: asmfun
Lang: | Patch: new
Platform: |
--------------------+-------------------------------------------------------
Changes (by jkeenan):
* status: new => assigned
* owner: => jkeenan
* keywords: => asmfun
* patch: => new
Old description:
> A trivial tweak... On platforms with assembly helpers (eg `asmfun.s` on
> ppc) the filename isn't printed when it's compiled during `make`, which
> can be briefly confusing.
New description:
A trivial tweak... On platforms with assembly helpers (eg `asmfun.s` on
ppc) the filename isn't printed when it's compiled during `make`, which
can be briefly confusing.
--
Comment:
Replying to [ticket:480 wiml]:
> A trivial tweak... On platforms with assembly helpers (eg `asmfun.s` on
ppc) the filename isn't printed when it's compiled during `make`, which
can be briefly confusing.
1. On Linux/i386 -- an OS which presumably ''would not'' be affected by
the application of this patch -- I got the following differences in my
`Makefile` between before and after patching:
{{{
$ diff -w 20090319.37602.parrot.txt
20090319.37602.parrot.with_cc_flags_patch.txt
5a6
> /usr/local/bin/perl tools/build/vtable_h.pl
345d345
< /usr/local/bin/perl -MExtUtils::Command -e cp src/jit/i386/exec_dep.h
src/exec_dep.h
351d350
< /usr/local/bin/perl -MExtUtils::Command -e cp src/jit/i386/exec_dep.c
src/exec_dep.c
}}}
Are these differences significant? (All tests in `make test` passed in
each case.)
2. Here is the before-and-after diff on Darwin -- an OS which presumably
''would'' be affected by the application of the patch:
{{{
$ diff -w 20090319.37602.parrot.txt \
> 20090319.37602.parrot.with_cc_flags_patch_darwin.txt
5a6
> /usr/local/bin/perl tools/build/vtable_h.pl
342a344
> src/asmfun.s
345d346
< /usr/local/bin/perl -MExtUtils::Command -e cp src/jit/ppc/exec_dep.h
src/exec_dep.h
351d351
< /usr/local/bin/perl -MExtUtils::Command -e cp src/jit/ppc/exec_dep.c
src/exec_dep.c
}}}
Why is the application of this patch triggering a call to
`tools/build/vtable_h.pl` on either OS?
On Darwin, all tests in `make test` passed both before and after patching.
So the patch seems to accomplish its objective and do no harm. But I
would like to know the reason and significance of these other differences
before application.
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/480#comment:2>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
