#489: t/tools/ops2pm/*.t:  Failures in 3 test files
---------------------+------------------------------------------------------
 Reporter:  jkeenan  |       Owner:            
     Type:  bug      |      Status:  new       
 Priority:  normal   |   Milestone:            
Component:  none     |     Version:            
 Severity:  medium   |    Keywords:  ops ops2pm
     Lang:           |       Patch:            
 Platform:  all      |  
---------------------+------------------------------------------------------
Changes (by jkeenan):

 * cc: allison (removed)
 * cc: alli...@… (added)


Comment:

 Here is something I noticed in the course of working on this ticket.

 Changeset 37670 includes the following:
 {{{
 Index: trunk/src/ops/core.ops
 ===================================================================
 --- a/trunk/src/ops/core.ops
 +++ b/trunk/src/ops/core.ops
 @@ -165,4 +165,16 @@
      Parrot_load_bytecode(interp, $1);
  }
 +
 +=item B<load_language>(in STR)
 +
 +Load the compiler libraries for a language $1. Search the library path to
 +locate the main compiler file in the standard locations.
 +
 +inline op load_language(in STR) :load_file {
 +    Parrot_load_language(interp, $1);
 +}
 +
 +
 +=cut

  =back
 }}}
 But this puts these two lines '''inside the POD''':
 {{{
   inline op load_language(in STR) :load_file {
      Parrot_load_language(interp, $1);
 }}}
 ... which means they're not active code.  Shouldn't it have been the
 following?
 {{{
 +=item B<load_language>(in STR)
 +
 +Load the compiler libraries for a language $1. Search the library path to
 +locate the main compiler file in the standard locations.
 +
 +=cut
 +
 +inline op load_language(in STR) :load_file {
 +    Parrot_load_language(interp, $1);
 +}
 +
 }}}
 `make` and `make test` completed successfully either way.  But I suspect
 only the latter is correct.

 Thank you very much.[[BR]]
 kid51

-- 
Ticket URL: <https://trac.parrot.org/parrot/ticket/489#comment:5>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets

Reply via email to