#548: Error handling in socket system
-------------------------+--------------------------------------------------
Reporter: whiteknight | Owner:
Type: RFC | Status: new
Priority: normal | Milestone:
Component: core | Version:
Severity: medium | Keywords: socket
Lang: | Patch:
Platform: all |
-------------------------+--------------------------------------------------
Browsing through the socket system, I see a few places where error
conditions don't seem to be handled in a way consistent with the rest of
Parrot. Some examples:
src/io/socket_win32.c:get_sockaddr_in(). there are a few "XXX" comments
here about poor error handling, and a bare fprintf(stderr, ...) call that
should probably be replaced with a Parrot_warn() or a thrown exception.
Same thing in src/io/socket_unit.c:get_sockaddr_in().
Various platform-specific functions are returning platform-specific error
codes, as is evidenced in places like
src/io/socket_api.c:Parrot_io_socket_is_closed(). We should have a more
unified way to say whether a function has succeeded or failed without
using a large ugly #ifdef/#endif chain
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/548>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
