#552: Evaluate all hack-identifying comments in source code
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: none | Version:
Severity: medium | Keywords: hack
Lang: | Patch:
Platform: all |
---------------------+------------------------------------------------------
Comment(by doughera):
Replying to [ticket:552 jkeenan]:
> A couple of years back, Paul T Cochrane grepped our repository for
'TODO', 'FIXME' and 'XXX' and created RT tickets for all comments
containing these strings. We've incorporated some of that in our test
suite.
{{{
./src/gc/system.c:78: double align_hack[2];
./src/gc/system.c:91: static void (*fn_ptr)(void) = (void
*)(void))&u.align_hack[0];
}}}
This section is already tracked in TT 271 (mentioned in the comments a few
lines earlier in the file.)
{{{
> ./src/jit/sun4/jit_emit.h:19: XXX Hack [perl #37819] below.
> ./src/jit/sun4/jit_emit.h:797:/* XXX Hack to fix the following bug as of
05 Dec 2005:
> ./src/jit/sun4/jit_emit.h:798: Hack [perl #37819] Sun4 builds fail
linking against jit.o
> ./src/jit/sun4/jit_emit.h:802: See also the "Hack [perl #37819]"
section near the bottom of this
> ./src/jit/sun4/jit_emit.h:824:/* XXX end blind hack for [perl #37819]
--but see
> ./src/jit/sun4/jit_emit.h:825: additional hack section at bottom.
> ./src/jit/sun4/jit_emit.h:1180:/* XXX Hack [perl #37819] Unlike the
functions above, this one
apparently
}}}
These are all tracked in the same RT #37819, which is unlikely to ever get
fixed. JIT is currently disabled on the sun4 architecture.
> ./lib/Parrot/Configure/Options/Conf.pm:83: --define=inet_aton Quick
hack to use inet_aton instead of inet_pton
Some years ago, I submitted a patch to handle this automatically, but it
was rejected.
> ./config/inter/make.pm:123: # RT#43171 this is an ugly hack
The last few entries in the RT accurately summarize the current state of
affairs for this.
> ./config/auto/alignptrs/test_c.in:43: printf("Soft failure hack
for systems that simulate unaligned access\n");
The word "hack" is perhaps unfortunate here -- the test is doing the right
thing in this case.
(Though ultimately, it doesn't matter, since the results of the test
aren't used anywhere.)
> ./config/auto/headers.pm:42: # headers we found so far. This is
somewhat a hack, but makes probing
This is also doing the right thing already. It's not really a "hack".
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/552#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
