#551: t/pmc/nci.t: 2 test failures
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: none | Version:
Severity: medium | Keywords: pmc nci pointer
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
Comment(by cotto):
With the attached patch, all tests pass (including the TODO'd ones) on
both jitcapable and non-jitcapable. The patch includes Whiteknight's
suggestion and rg's code, plus some changes to the nci thunk generation
code. There are two issues with it that I'd like addressed before I'm
comfortable applying it.
First, the patch changes nci_vp() in src/nci_test.c. I suspect that the
logic in that function needed to be updated, but on the other hand it was
working before as it was. I'm reasonably sure the change is correct, but
I'd appreciate independent confirmation.
Second, I'm not 100% certain about all the pointer dereferencing logic in
src/pmc/pointer.pmc. get_string and get_pointer are the only functions
that have any test coverage, so a quick check by someone else would be
helpful.
Once those issues are addressed, the patch can be applie and this ticket
resolved.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/551#comment:8>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
