#586: tools/dev/install_files.pl: bug masked by missing file in
MANIFEST.generated
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: bug | Status: assigned
Priority: normal | Milestone:
Component: none | Version: trunk
Severity: medium | Keywords:
Lang: | Patch: new
Platform: |
---------------------+------------------------------------------------------
Changes (by jkeenan):
* cc: fperrad, allison (added)
* patch: => new
Comment:
Replying to [ticket:586 jkeenan]:
> The '''short version''': Should `installable_pirc.exe` have been
included in ''MANIFEST.generated''? If so, then a bug in
''tools/dev/install_files.pl'' has been masking that deficiency.
>
> The '''long version''': An entry for file ''pirc.exe'' was added to
MANIFEST.generated in r37438. Unlike other ''.exe'' files, no
corresponding ''installable_pirc.exe'' file was added to
MANIFEST.generated at that time.
...
> So, should `installable_pirc.exe` have been included in
''MANIFEST.generated''? Since this is a Win32 file and I don't have
access to that OS, it would be good if someone can see whether
`installable_pirc.exe` is, in fact, generated during the Parrot build
process. If so, then we can safely add it to ''MANIFEST.generated''. I
will then fix the code in ''install_files.pl''.
>
Follow-up, hoping for feedback from fperrad and allison:
In responding to TT #347 with r38393, Allison removed from
''MANIFEST.generated'' those executable files whose names did '''not'''
begin with `installable_`. That may enable further simplification of
''tools/dev/install_files.pl''. But, more immediately, that leads me to
believe that ''pirc'' and ''pirc.exe'' should '''not''' be in
''MANIFEST.generated'' but that ''installable_pirc'' and
''installable_pirc.exe'' '''should be'''.
Do you agree? If so, we can apply the patch I'm about to attach when we
correct ''tools/dev/install_files.pl'' as well.
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/586#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
