#509: tools/dev/install_files.pl did not care about symlinks
----------------------+-----------------------------------------------------
Reporter: gerd | Type: todo
Status: new | Priority: major
Milestone: | Component: install
Version: 1.0.0 | Severity: medium
Keywords: | Lang:
Patch: rejected | Platform: linux
----------------------+-----------------------------------------------------
Changes (by jkeenan):
* cc: allison (added)
Comment:
Replying to [comment:3 gerd]:
> The file copying part as gone from tools/dev/install_files.pl to
lib/Parrot/Install.pm.
> So I add the new patch Install.pm.diff to take care of links. Is is
tested under Fedora and by building rpms.
gerd,
I did a diff between the patch you submitted 2 months ago and the one
submitted 12 hours ago. I found no material difference between them:
{{{
$ diff -w gerd.install_files.patch gerd.Install.pm.diff
1,3c1,3
< --- tools/dev/install_files.pl 2009-03-18 05:56:44.000000000
+0100
< +++ tools/dev/install_files.pl.new 2009-03-28 07:30:57.000000000
+0100
< @@ -292,6 +292,16 @@
---
> --- lib/Parrot/Install.pm 2009-06-01 09:29:57.000000000 +0200
> +++ lib/Parrot/Install.pm.new 2009-06-03 08:41:22.000000000 +0200
> @@ -220,6 +220,16 @@
17c17
< copy( $src, $dest ) or die "copy $src to $dest: $!\n";
---
> copy( $src, $dest ) or die "Error: couldn't copy $src to
$dest: $!\n";
}}}
Only the content of the `die` message has changed.
Assuming that my analysis is correct, it would seem that Allison's
objection to your original patch would apply to the new one as well.
I don't claim tremendous expertise in this area, but I wonder if there's
some other rationale you can provide here.
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/509#comment:4>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
