#455: [TODO] Change name of 'Parrot_add_library_path' to
'Parrot_pf_add_library_path_from_cstring'
---------------------+------------------------------------------------------
Reporter: allison | Owner: allison
Type: todo | Status: new
Priority: normal | Milestone: 1.4
Component: none | Version:
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
Comment(by jkeenan):
Replying to [comment:3 jkeenan]:
> This suggests that we could work on this ticket right away. Am I
correct in thinking that this will largely be a matter of changing all
instances of `Parrot_add_library_path` to
`Parrot_lib_add_path_from_cstring` -- much of which has already been done
-- and then making all tests pass?
>
> If so, then I will take the ticket and prepare a patch.
>
I created the ''add_library_path_remove'' branch in SVN to work on this.
I got as far as the attached patch, ''add_library_path.diff''. At that
point I began to get build warnings such as:
{{{
src/packfile.c:4776: warning: passing argument 2 of
'Parrot_add_library_path_from_cstring' from incompatible pointer type
src/packfile.c:4778: warning: passing argument 2 of
'Parrot_add_library_path_from_cstring' from incompatible pointer type
}}}
Subsequent discussion on IRC #parrot with Infinoid and NotFound suggested
that more needed to be done for this TT than I originally understood:
{{{
09:21 NotFound "The C string version will simply convert the C string to a
Parrot STRING and call 'Parrot_lib_add_path'."
09:21 NotFound So, the ticket ask for the two versions.
09:22 Infinoid Oh, I see. So the callers of the old function (who are
right to call the old function) should now call Parrot_lib_add_path(),
instead
09:22 NotFound The naming used seem confusing, anyway.
09:22 kid51 So this is more than a simple "rip out this feature"
deprecation.
09:22 Infinoid It's a "rename this function to that, and add this other
function to make some of the callers cleaner"
09:23 NotFound Is renamimg a function and adding another.
09:23 Infinoid You've got the "this other function" part done
}}}
So, anyone who has a better understanding of these issues is welcome to
take a crack at them in the ''add_library_path_remove'' branch.
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/455#comment:4>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
