#760: readline_interactive method no longer returns PMCNULL on eof
----------------------+-----------------------------------------------------
 Reporter:  flh       |        Type:  patch  
   Status:  new       |    Priority:  blocker
Milestone:            |   Component:  core   
  Version:  trunk     |    Severity:  release
 Keywords:            |        Lang:  tcl    
    Patch:  rejected  |    Platform:  all    
----------------------+-----------------------------------------------------

Comment(by NotFound):

 My fault, forgot to take a note for commenting it at parrotsketch. The
 behavior has been reverted, yes.

 The problem is that the method return a STRING * when not eof and PMCNULL
 when EOF, so if a string register is used for the returned value we get a
 PMCNULL access on EOF. Returning NULL makes more sense but breaks existing
 code, as this ticket shows, so it need a proposal for deprecation.

 On the other part, setting the EOF flag *after* reading EOF is a
 reasonable behavior and can be easily implemented.

-- 
Ticket URL: <https://trac.parrot.org/parrot/ticket/760#comment:9>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets

Reply via email to