#1059: Run Parrot through cpplint.py
------------------------------+---------------------------------------------
Reporter: petdance | Owner: petdance
Type: cage | Status: new
Priority: minor | Milestone:
Component: coding_standards | Version: 1.6.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: all |
------------------------------+---------------------------------------------
Comment(by jkeenan):
Replying to [ticket:1059 petdance]:
>
> Let's throw it at the Parrot source and see what shakes loose.
Doesn't work on ''.c'' files:
{{{
$ python cpplint.py src/string/primitives.c
Ignoring src/string/primitives.c; not a .cc or .h file
Done processing src/string/primitives.c
Total errors found: 0
}}}
Does work on ''.h'' files -- but they're coding standards are probably
different from ours, so a lot of noise would be generated:
{{{
python cpplint.py ./src/string/charset/iso-8859-1.h
./src/string/charset/iso-8859-1.h:13: #ifndef header guard has wrong
style, please use: PARROT_SRC_STRING_CHARSET_ISO_8859_1_H_
[build/header_guard] [5]
./src/string/charset/iso-8859-1.h:42: #endif line should be "#endif //
PARROT_SRC_STRING_CHARSET_ISO_8859_1_H_" [build/header_guard] [5]
./src/string/charset/iso-8859-1.h:17: Lines should be <= 80 characters
long [whitespace/line_length] [2]
./src/string/charset/iso-8859-1.h:39: Lines should be <= 80 characters
long [whitespace/line_length] [2]
Done processing ./src/string/charset/iso-8859-1.h
Total errors found: 4
}}}
I suspect we would have to adapt it heavily to be useful.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1059#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
