#1132: t/steps/auto/frames-01.t: Failures following pcc_reapply merge
-----------------------+----------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: todo | Status: new
Priority: normal | Milestone:
Component: configure | Version: 1.6.0
Severity: medium | Keywords: configure frames
Lang: | Patch:
Platform: |
-----------------------+----------------------------------------------------
With the merge of the ''pcc_reapply'' branch into trunk today at r41972,
the following changes were made to ''config/auto/frames.pm'':
{{{
svn diff -r {2009-10-20} config/auto/frames.pm
Index: config/auto/frames.pm
===================================================================
--- config/auto/frames.pm (revision 41946)
+++ config/auto/frames.pm (working copy)
@@ -40,6 +40,7 @@
sub _call_frames_buildable {
my $conf = shift;
+
my $osname = $conf->data->get('osname');
my $cpuarch = $conf->data->get('cpuarch');
my $nvsize = $conf->data->get('nvsize');
@@ -49,8 +50,10 @@
$can_build_call_frames = $conf->options->get('buildframes');
}
else {
- $can_build_call_frames = ($nvsize == 8 && $cpuarch eq 'i386'
- && $osname ne 'darwin');
+ # Temporary disable build frames automatically.
+ #$can_build_call_frames = ($nvsize == 8 && $cpuarch eq 'i386'
+ # && $osname ne 'darwin');
+ $can_build_call_frames = 0;
}
return $can_build_call_frames;
}
}}}
This temporary disabling of build frames functionality had the effect of
causing two failures in ''t/steps/auto/frames-01.t'':
{{{
prove -v t/steps/auto/frames-01.t
...
not ok 12 - Result is 'yes', as expected
# Failed test 'Result is 'yes', as expected'
# at t/steps/auto/frames-01.t line 47.
# got: 'no'
# expected: 'yes'
ok 13 - _call_frames_buildable() returned true value, as expected
ok 14 - _call_frames_buildable() returned false value, as expected
not ok 15 - _call_frames_buildable() returned true value, as expected
(i386/non darwin/8)
# Failed test '_call_frames_buildable() returned true value, as expected
(i386/non darwin/8)'
# at t/steps/auto/frames-01.t line 72.
}}}
Apparently no one ran `perl Configure.pl --test` at the time of merge.
The failing tests should either have been modified to conform to the new
code in `auto::frames` or they should have been `TODO`ed and a TT created
to track the `TODO` item.
I'm going to elect to follow the second course of action. This ticket
exists to track the restoration of 'normal' build frames functionality and
the full testing of the code by which we probe for that functionality.
Thank you very much.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1132>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
