#423: config/auto/arch.pm can get wrong architecture on solaris/x86
-----------------------+----------------------------------------------------
Reporter: doughera | Owner: jkeenan
Type: bug | Status: assigned
Priority: minor | Milestone:
Component: configure | Version:
Severity: low | Keywords:
Lang: | Patch: applied
Platform: solaris |
-----------------------+----------------------------------------------------
Changes (by jkeenan):
* owner: => jkeenan
* status: new => assigned
* patch: => applied
Comment:
Replying to [comment:2 doughera]:
Andy,
Since you originally submitted your patch ''config/auto/jit.pm'' has been
substantially gutted as part of the replacement of our dysfunctional JIT
system. So, when I went to apply your patch to trunk, I got this result:
{{{
$ patch -p1 < ~/learn/parrot/patches/tt423-solaris-archname.patch
patching file config/auto/arch.pm
patching file config/auto/jit.pm
Hunk #1 FAILED at 173.
1 out of 1 hunk FAILED -- saving rejects to file config/auto/jit.pm.rej
}}}
The ''.rej'' file had this content:
{{{
$ cat config/auto/jit.pm.rej
***************
*** 173,178 ****
if ( $cpuarch eq 'i386' && $osname eq 'darwin' ) {
$jitcapable = 0;
}
}
return $jitcapable;
}
--- 173,182 ----
if ( $cpuarch eq 'i386' && $osname eq 'darwin' ) {
$jitcapable = 0;
}
+ # And another exception (TT #423)
+ if ( $cpuarch eq 'i386' && $osname eq 'solaris' ) {
+ $jitcapable = 0;
+ }
}
return $jitcapable;
}
}}}
So, I'm applying only the ''config/auto/arch.pm'' part of the patch.
Since I don't have a Solaris box to test on, we'll have to rely on you and
other Solaris testers to report any problems once the patch is applied.
It would be good if we could have some Solaris testers report on `make
fulltest`.
Did no harm to `make test` on Linux/i386, as per
[http://smolder.plusthree.com/app/public_projects/report_details/29478
this Smolder report]. Applied to trunk in r42159.
For recordkeeping purposes, I'm taking ownership of the ticket. But since
I don't have Solaris, any dev with Solaris is encouraged to steal the
ticket from me. Thank you very much.[[BR]]
[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/423#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
