#1257: src/io/utf8.c: Does the amount read in Parrot_io_read_utf8() need to be
checked?
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner:
Type: todo | Status: new
Priority: normal | Milestone:
Component: core | Version: 1.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
This ticket moves into Trac discussion of an issue originally tracked in
RT at [http://rt.perl.org/rt3/Ticket/Display.html?id=46413 RT #46413].
In that RT, Paul Cochrane cited lines in the file now known as
''src/io/utf8.c'':
{{{
46 size_t
47 Parrot_io_read_utf8(PARROT_INTERP, ARGMOD(PMC *filehandle),
48 ARGMOD(STRING **buf))
49 {
...
83 /* RT#46413 need to check the amount read here? */
84 read = Parrot_io_read_buffer(interp,
filehandle, &s2 );
85 UNUSED(read);
}}}
Paul commented, ''"At present this variable is marked UNUSED(read).
However, it might be a good idea to actually check the amount read in this
function call. After which the UNUSED() needs to disappear."''
Can someone follow up?
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1257>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
