#1272: Problems with codetest on files in ext/ directory (should ext/ be
included
in codetest?)
---------------------+------------------------------------------------------
Reporter: mikehh | Owner:
Type: RFC | Status: new
Priority: normal | Milestone:
Component: testing | Version: 1.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
I have recently been getting codetest failures with
t/codingstd/pod_syntax.t in ext/nqp-rx
I did fix the files in question (redundant =cut at the end) but found that
there were a whole bunch of trailing spaces that my editor removed on
saving the file that were not picked up by the trailing spaces test.
Subsequent commits to that directory did not include the fixes I made and
I was required to redo the fixes.
The situation is that we should either run all codingstd tests on the
files in the ext directory or none.
We should bear in mind that the files in the ext directory are external to
parrot.
pmichaud++ stated that the files are generated and that it would be
difficult to fix the generator to prevent the generation of trailing
spaces.
also:
<pmichaud> mikehh: imo, we shouldn't be running codetest on things in
ext/[[BR]]
<pmichaud> mikehh: if you're editing the files in ext/nqp-rx, it won't do
much good -- they get overwritten by newer versions
The problem is that the fixes are not 'permanent' and the next time the
code is committed to parrot, if the fixes have not been included upstream
the failure re-occurs.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1272>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
