#1343: parrot's Test::More's is(Float,Float), with precision
--------------------+-------------------------------------------------------
Reporter: coke | Owner:
Type: todo | Status: new
Priority: normal | Milestone:
Component: none | Version: trunk
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
--------------------+-------------------------------------------------------
This option needs better docs in the pod. (specifically, what do you pass
in?)
It's defined as a pmc type, but is cast to num and used that way - should
probably just be declared as a num type. [0]
Also, when passed, the floats are still compared with iseq first; I would
suggest that if we're declaring we want it, we should avoid the direct
comparison and just check the diff.
[0](This actually seems to be a common theme with many options across
several test::more subs- e.g. is :multi(PMC,Float), but the float
parameter is declared as a .pmc, and then cast to a .num - also, many uses
of _make_diagnostic first cast the passed in args to string, despite the
fact that the sub declares the parameters as string itself)
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1343>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets