#1345: [PATCH] eliminate {push,shift}_opcode_pmc from pmc_freeze
----------------------+-----------------------------------------------------
 Reporter:  plobsing  |        Type:  patch 
   Status:  new       |    Priority:  normal
Milestone:            |   Component:  core  
  Version:  1.8.0     |    Severity:  medium
 Keywords:            |        Lang:        
    Patch:            |    Platform:        
----------------------+-----------------------------------------------------
 The pseudo-pmc used in pmc freeze/thaw includes operations that appear to
 mimic push/shift PMC.

 Except: they don't push/shift a PMC to/from the image buffer. They
 push/shift a PMC ID, which is really just another integer as far as the
 image is concerned.

 This is confusing and also leads to needless casting to/from PMC* of
 values that aren't really pointers.

 The attached patch replaces all use of these operations with
 {push,shift}_integer.

-- 
Ticket URL: <https://trac.parrot.org/parrot/ticket/1345>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets

Reply via email to