#1218: [PATCH] t/dynpmc/foo2.t converted to PIR
----------------------+-----------------------------------------------------
Reporter: bubaflub | Owner: Util
Type: bug | Status: closed
Priority: trivial | Milestone:
Component: testing | Version: 1.7.0
Severity: low | Resolution: fixed
Keywords: | Lang:
Patch: | Platform:
----------------------+-----------------------------------------------------
Changes (by Util):
* status: assigned => closed
* resolution: => fixed
Comment:
== Regarding combining the .t files: ==
Since foo.pmc is separate from foo2.pmc, but they are compiled together
into a single foo_group library, it would make sense to combine the .t
files.
Logically, the resulting .t file would be named foo_group.t, not foo.t.
However, since I expect foo.t to be split into multiple tests (see TT
#1217), we should not merge foo2.t (unless foo.t is decided to remain
intact).
== Regarding the patch itself: ==
The code changes looks great!
Also, you were correct to change the copyright date from its erroneous
`2005` value, but since the file was written in 2009, the range
`2001-2009` is not appropriate.
With that one correction, patch applied in r42950.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1218#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
