#1382: auto::alignptrs: Eliminate this config step
-----------------------+----------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: RFC | Status: assigned
Priority: normal | Milestone:
Component: configure | Version: 1.9.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
-----------------------+----------------------------------------------------
Comment(by jkeenan):
I've attached a diff between branch and trunk which should be considered
as a first draft of a patch implementing the removal of `auto::alignptrs`.
So far, all I've done is to comment out the two `PARROT_ASSERT` lines.
{{{
Index: src/pmc/unmanagedstruct.pmc
===================================================================
--- src/pmc/unmanagedstruct.pmc (revision 43151)
+++ src/pmc/unmanagedstruct.pmc (revision 43153)
@@ -185,7 +185,9 @@
/* now point ptr to the real data */
if (*type == enum_type_struct_ptr) {
/* that is either a pointer */
+ /*
PARROT_ASSERT((PTR2INTVAL(p) & (PARROT_PTR_ALIGNMENT -
1)) == 0);
+ */
VTABLE_set_pointer(interp, init, *(void**)p);
}
@@ -199,7 +201,9 @@
* p is the location of the struct pointer in the
* outer struct, the inner is at PMC_data(init) */
+ /*
PARROT_ASSERT((PTR2INTVAL(p) & (PARROT_PTR_ALIGNMENT - 1)) ==
0);
+ */
*(void **)p = VTABLE_get_pointer(interp, init);
}
}}}
I suspect that deleting those two lines, including their reference to
`PTR2INTVAL` is probably not the best way to proceed, even if it works.
Should there be some other `PARROT_ASSERT` there?
Suggestions?
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1382#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
