#1249: t/pmc/threads.t: Thread types tests need rework
---------------------+------------------------------------------------------
Reporter: jkeenan | Owner:
Type: cage | Status: new
Priority: normal | Milestone:
Component: testing | Version: 1.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
Comment(by Infinoid):
The TODO comment was added in r14131, and it refers to a couple of tests
(directly below the comment) named "thread type 1" and "thread type 2".
When the tests were added (in r4993), the only apparent difference between
the two "types" was whether the thread function took any arguments or not.
The first test didn't pass an argument; the second test did. Today, that
remains the only difference. (The two tests have since grown into 3, but
the distinction is still the same.) So it seems safe to assume that's
what was referred to by "thread type".
Since that's still a valid distinction, it seems reasonable to keep
testing both cases. So, I don't think any refactoring of the tests is
required.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1249#comment:2>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
