#854: config/inter/progs.pm: Figure out why -libpath: needs to be removed from
$linkflags and $ldflags
-----------------------+----------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: cage | Status: assigned
Priority: minor | Milestone:
Component: configure | Version: 1.3.0
Severity: low | Keywords:
Lang: | Patch:
Platform: |
-----------------------+----------------------------------------------------
Changes (by jkeenan):
* owner: => jkeenan
* status: new => assigned
Comment:
Replying to [ticket:854 jkeenan]:
Reviewing this old ticket today, I tried to answer this question:
>
> 2. What is the harm caused by leaving a string matching that pattern in
Parrot::Configure's `linkflags` or `ldflags` attributes?
>
... by simply commenting out the lines where the Trac references appeared:
{{{
$ svn diff config/inter/progs.pm
Index: config/inter/progs.pm
===================================================================
--- config/inter/progs.pm (revision 48718)
+++ config/inter/progs.pm (working copy)
@@ -103,13 +103,13 @@
$conf->debug("\nccflags: $ccflags\n");
$linkflags = $conf->data->get('linkflags');
- $linkflags =~ s/-libpath:\S+//g; # TT #854: No idea why.
+# $linkflags =~ s/-libpath:\S+//g; # TT #854: No idea why.
$linkflags = integrate( $linkflags, $conf->options->get('linkflags')
);
$linkflags = prompt( "And flags for your linker?", $linkflags ) if
$ask;
$conf->data->set( linkflags => $linkflags );
$ldflags = $conf->data->get('ldflags');
- $ldflags =~ s/-libpath:\S+//g; # TT #854: No idea why.
+# $ldflags =~ s/-libpath:\S+//g; # TT #854: No idea why.
$ldflags = integrate( $ldflags, $conf->options->get('ldflags') );
$ldflags = prompt( "And your $ld flags for building shared
libraries?", $ldflags )
if $ask;
}}}
I configured both before and after applying this patch and, after the
second run, `diff`-ed ''lib/Parrot/Config/Generated.pm''. There were no
meaningful differences between 'before' and 'after' on either Linux/i386
or Darwin/PPC. `make test` had no failures on either platform after the
change.
If we could get this patch tested on other platforms and demonstrate no
harm, then we could close this ticket.
Thank you very much.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/854#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
